Bug 1095000
Summary: | EAP 6 WebConnectorComponent computes an incorrect default max-connections property value | |||
---|---|---|---|---|
Product: | [JBoss] JBoss Operations Network | Reporter: | Larry O'Leary <loleary> | |
Component: | Plugin -- JBoss EAP 6 | Assignee: | RHQ Project Maintainer <rhq-maint> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Armine Hovsepyan <ahovsepy> | |
Severity: | medium | Docs Contact: | ||
Priority: | unspecified | |||
Version: | JON 3.2 | CC: | ahovsepy, jlivings, lkrejci, mfoley, mkoci, rhatlapa | |
Target Milestone: | DR01 | |||
Target Release: | JON 3.3.0 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: |
The JBossWeb Connector resource component attempted to determine the value for "Max Connections" if the underlying JBoss EAP server indicated the value was undefined. This caused an incorrect value to be set for the property if the underlying connector implementation was not the default JIO connector type. The JBossWeb Connector resource no longer sets a calculated "Max Connections" value, and defers to JBoss EAP and its connector subsystem to determine the default based on the connector implementation. When "Max Connections" is "unset", it no longer overrides the connector's default implementation for maximum connections.
|
Story Points: | --- | |
Clone Of: | ||||
: | 1119863 (view as bug list) | Environment: | ||
Last Closed: | 2014-12-11 14:02:54 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1091235, 1119863 |
Description
Larry O'Leary
2014-05-06 22:15:26 UTC
The exact logic is: Normally, JIO is used (http://anonsvn.jboss.org/repos/jbossweb/branches/7.4.x/src/main/java/org/apache/tomcat/util/net/JIoEndpoint.java): -- maxThreads = (org.apache.tomcat.util.Constants.LOW_MEMORY) ? 64 : ((Constants.MAX_THREADS == -1) ? 512 * Runtime.getRuntime().availableProcessors() : Constants.MAX_THREADS); APR (native) http://anonsvn.jboss.org/repos/jbossweb/branches/7.4.x/src/main/java/org/apache/tomcat/util/net/AprEndpoint.java -- maxThreads = (org.apache.tomcat.util.Constants.LOW_MEMORY) ? 32 : ((Constants.MAX_THREADS == -1) ? 32 * Runtime.getRuntime().availableProcessors() : Constants.MAX_THREADS); NIO (unsupported I think) - http://anonsvn.jboss.org/repos/jbossweb/branches/7.4.x/src/main/java/org/apache/tomcat/util/net/NioEndpoint.java, http://anonsvn.jboss.org/repos/jbossweb/branches/7.4.x/src/main/java/org/apache/tomcat/util/net/AbstractEndpoint.java) -- maxThreads = (org.apache.tomcat.util.Constants.LOW_MEMORY) ? 32 : ((Constants.MAX_THREADS == -1) ? 32 * Runtime.getRuntime().availableProcessors() : Constants.MAX_THREADS); So usually 32 * cpus for native and 512 * cpus otherwise as Larry says. in master commit ff200f352243cae35993485062844c0d3a17e09c Author: Lukas Krejci <lkrejci> Date: Mon Jul 21 22:00:59 2014 +0200 [BZ 1095000] Don't try to guess web connector's max connections. commit 735365ddbf20409003e7ede9f47d4489a0f6c41a Author: Lukas Krejci <lkrejci> Date: Tue Jul 22 16:22:13 2014 +0200 [BZ 1095000] Fix test failures. Moving to ON_QA as available to test with brew build of DR01: https://brewweb.devel.redhat.com//buildinfo?buildID=373993 moving to VERIFIED All test cases as discussed with Larry passed when tested on both http and ajp connector: - the value Max Connections is unset by default -> ok, EAP CLI shows 'undefined' if connector resource is read - changing unrelated configuration does not break configuration update -> ok, changing value of 'Max Save Post Size' succeeds, change can be seen also using EAP CLI - changing 'Max Connections' to some seemingly valid value -> ok, chaning value to 512 succeeds, change can be seen also using EAP CLI - re-check the unset checkbox again -> ok, configuration change suceeds, EAP CLI shows 'undefined' again Version:3.3.0.DR01 Build Number:6468454:dda0a47 Hey Armine, can you please help me out with some release note text for this issue. I'm drawing blanks when I try to create a succinct explanation for the fix and result. |