Bug 1357617

Summary:	plugin_scheduler taskset errors during rollback
Product:	Red Hat Enterprise Linux 7	Reporter:	Jaroslav Škarvada <jskarvad>
Component:	tuned	Assignee:	Jaroslav Škarvada <jskarvad>
Status:	CLOSED ERRATA	QA Contact:	Tereza Cerna <tcerna>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.2	CC:	jeder, jen, jskarvad, olysonek, qe-baseos-daemons, tcerna
Target Milestone:	rc	Keywords:	Patch, Upstream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tuned-2.9.0-0.1.rc1.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1252160	Environment:
Last Closed:	2018-04-10 16:01:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1400961, 1467576, 1472751, 1485946

Comment 3 Ondřej Lysoněk 2017-10-02 11:41:03 UTC

I think this should be already fixed (more or less) by
https://github.com/redhat-performance/tuned/commit/f9f5b073a599c

The taskset errors are probably caused by trying to set affinity of some kernel threads. The commit above changes the log level of the errors related to kernel threads to debug, so you won't see them anymore.

Jeff, could you test the following test build? If you still see the errors, please attach another log from a run in debug mode.
https://olysonek.fedorapeople.org/tuned/tuned-2.8.0-6testonly/
It was built from this branch:
https://github.com/olysonek/tuned/tree/fixes

The commit above should hide the errors, but there's another problem. I think the scheduler plugin does rollback of settings which were not really set. E.g. if you have the following in a profile:
[scheduler]
group.ksoftirqd=0:f:2:*:ksoftirqd.*

then the cpu affinity will not be set when the profile is applied ('*' is used as the affinity), but tuned will try to set the original affinity, when the profile is unapplied. I propose we fix this when we get around to refactoring the scheduler plugin a bit, as I don't think this is terribly important and I don't feel like going through the code again only because of this :).

Comment 4 Jeff Nelson 2017-10-07 16:42:52 UTC

In Comment #3, Ondřej writes:
>Jeff, could you test the following test build? If you still see the errors,
>please attach another log from a run in debug mode.
>https://olysonek.fedorapeople.org/tuned/tuned-2.8.0-6testonly/
>It was built from this branch:
>https://github.com/olysonek/tuned/tree/fixes

Sorry, I am in a different position than when I originally reported this problem and I won't have time to verify this test build. Is this something you could ask QE to test?

Comment 5 Ondřej Lysoněk 2017-10-13 15:01:02 UTC

Well this is the sort of bug which would be best tested in your environment. Otherwise we can't be sure it's really fixed, as there might be more unrelated issues. So let's just hope it's fixed, I guess :).

Comment 10 errata-xmlrpc 2018-04-10 16:01:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0879