Bug 1720114 (CVE-2019-10166)

Summary: CVE-2019-10166 libvirt: virDomainManagedSaveDefineXML API exposed to readonly clients
Product: [Other] Security Response Reporter: Doran Moppert <dmoppert>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: agedosier, berrange, clalancette, cperry, dblechte, dfediuck, eblake, eedri, erik-fedora, itamar, jdenemar, jforbes, jsuchane, knoel, laine, libvirt-maint, marcandre.lureau, mgoldboi, michal.skrivanek, pkrempa, rbalakri, richard.poettler, rjones, sbonazzo, security-response-team, sherold, sisharma, ssaha, vbellur, veillard, virt-maint, yturgema
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libvirt 4.10.1, libvirt 5.4.1 Doc Type: If docs needed, set a value
Doc Text:
It was discovered that libvirtd would permit readonly clients to use the virDomainManagedSaveDefineXML() API, which would permit them to modify managed save state files. If a managed save had already been created by a privileged user, a local attacker could modify this file such that libvirtd would execute an arbitrary program when the domain was resumed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-12 13:07:40 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1720498, 1720502, 1720507, 1720512, 1720516, 1720520, 1720524, 1720528, 1720530, 1722462, 1722465    
Bug Blocks: 1718800    

Description Doran Moppert 2019-06-13 07:53:24 UTC
It was discovered that libvirtd would permit readonly clients to use the
virDomainManagedSaveDefineXML() API, which would permit them to modify 
managed save state files.  If a managed save had already been created by 
a privileged user, a local attacker could modify this file such that 
libvirtd would execute an arbitrary program when the domain was resumed.

This vulnerability was first present in libvirt v3.6.1.

Comment 4 Hardik Vyas 2019-06-19 07:09:56 UTC
Statement:

* This vulnerability requires access to the libvirt socket, normally in /var/run/libvirt/libvirt_sock_ro.  Typically in hypervisor environments, local user accounts are not supported so no untrusted users should be able to access this socket.
* Red Hat Gluster Storage 3 is not affected by this vulnerability as libvirtd daemon is not shipped in Gluster.

Comment 5 Doran Moppert 2019-06-20 02:05:40 UTC
External References:

https://access.redhat.com/libvirt-privesc-vulnerabilities

Comment 6 Doran Moppert 2019-06-20 02:05:42 UTC
Mitigation:

The Unix permissions of libvirt's read-only socket can be made more restrictive than the default (0777) by editing `/etc/libvirt/libvirtd.conf`.  The settings `unix_sock_group = libvirt` and `unix_sock_ro_perms = 0770` will restrict access to only members of `libvirt`, who already have management access to virtual machines.

Comment 8 Doran Moppert 2019-06-20 12:14:20 UTC
Created libvirt tracking bugs for this issue:

Affects: fedora-all [bug 1722462]


Created mingw-libvirt tracking bugs for this issue:

Affects: fedora-all [bug 1722465]

Comment 9 errata-xmlrpc 2019-06-20 15:33:23 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 7

Via RHSA-2019:1579 https://access.redhat.com/errata/RHSA-2019:1579

Comment 10 errata-xmlrpc 2019-06-20 15:48:23 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8

Via RHSA-2019:1580 https://access.redhat.com/errata/RHSA-2019:1580

Comment 11 Doran Moppert 2019-07-02 04:32:03 UTC
Acknowledgments:

Name: Matthias Gerstner (SUSE)

Comment 13 errata-xmlrpc 2019-07-08 09:19:03 UTC
This issue has been addressed in the following products:

  Red Hat Virtualization 4 for Red Hat Enterprise Linux 7

Via RHSA-2019:1699 https://access.redhat.com/errata/RHSA-2019:1699

Comment 14 errata-xmlrpc 2019-07-11 16:26:02 UTC
This issue has been addressed in the following products:

  Red Hat Enterprise Linux 8 Advanced Virtualization

Via RHSA-2019:1762 https://access.redhat.com/errata/RHSA-2019:1762

Comment 15 Product Security DevOps Team 2019-07-12 13:07:40 UTC
This bug is now closed. Further updates for individual products will be reflected on the CVE page(s):

https://access.redhat.com/security/cve/cve-2019-10166