Bug 2218233

Summary: ansible-core: Python tarfile extraction needs change to avoid a warning (CVE-2007-4559 mitigation)
Product: Red Hat Enterprise Linux 8 Reporter: Charalampos Stratakis <cstratak>
Component: ansible-coreAssignee: Dimitri Savineau <dsavinea>
Status: CLOSED MIGRATED QA Contact: Matt Clay <mclay>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.9CC: dsavinea, jwboyer, mclay, pviktori
Target Milestone: rcKeywords: MigratedToJIRA
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 2203890 Environment:
Last Closed: 2023-09-12 10:19:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 263261    

Description Charalampos Stratakis 2023-06-28 13:57:37 UTC
+++ This bug was initially created as a clone of Bug #2203890 +++

Hello,
In RHEL 9.3 and 8.9, we're planning to fix the long-standing CVE-2007-4559: Python's `tarfile` module makes it too easy to extract tarballs in an unsafe way.
Unfortunately, for the CVE to be considered fixed, this needs a behavior change. (If you don't think this is the case, let's bring it up with the security team.)
Upstream, Python will emit deprecation warnings for 2 releases, but in RHEL we change the behavior now, emit warnings, and provide ways for customers to restore earlier behavior.
To avoid the warning, software shipped by Red Hat will need a change.

For more details see upstream PEP 706: https://peps.python.org/pep-0706
and the Red Hat knowledge base draft: https://access.redhat.com/articles/7004769

---

In /usr/lib/python3.11/site-packages/ansible/galaxy/role.py, ansible-core calls `role_tar_file.extract()`. The call will emit a warning by default, and should be changed to something like:

if hasattr(tarfile, 'data_filter'):
    # Python with CVE-2007-4559 mitigation (PEP 706)
    role_tar_file.extract(..., filter='data')
else:
    # Fallback to a possibly dangerous extraction (before PEP 706)
    role_tar_file.extract(...)

The 'data' filter above attempts a "safe" extraction, intended for pure data archives. For example:
- prevents extracting outside the target directory, and to absolute paths (by raising an exception)
- prevents symlinks pointing outside the target directory, and to absolute paths
- adjusts permissions (for the owner, only the executable bit is honored)
See PEP 706 for details: https://peps.python.org/pep-0706/#filters

If you trust your validation, use `filter='fully_trusted'` instead. That will preserve the existing behavior.
(I don't know if you are concerned about *this* tarball being malicious. At first glance, your validation won't prevent malicious tarballs from extracting outside `self.path`. Happy to elaborate.)

---

Let me know if you have any questions!

Comment 1 Petr Viktorin (pviktori) 2023-06-30 11:31:46 UTC
On RHEL8, the ansible-test subpackage calls `extractall` in /usr/lib/python3.11/site-packages/ansible_test/_internal/commands/sanity/validate_modules.py
This call needs to be adjusted in the same way.

Comment 2 RHEL Program Management 2023-09-12 10:15:36 UTC
Issue migration from Bugzilla to Jira is in process at this time. This will be the last message in Jira copied from the Bugzilla bug.

Comment 3 RHEL Program Management 2023-09-12 10:19:07 UTC
This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "RHEL-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.