Bug 544628
Summary: | at-spi2-core - Protocol definitions and daemon for D-Bus at-spi | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> |
Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | ben, fedora-package-review, notting, tomspur, zcerza |
Target Milestone: | --- | Flags: | tomspur:
fedora-review+
dennis: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-01-05 02:27:17 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 544629, 544630 |
Description
Matthias Clasen
2009-12-05 19:34:47 UTC
Just a few comments: - There is no conflicts with the at-spi packages as described above, yet. - source url is wrong: should be download*DOT*gnome*DOT*org This one is not conflicting. The at-spi2-atk and pyatspi packages are, though. Review: Good: - license ok - name ok - buildroot ok (unneeded in fedora) - parallel make - %clean section there - %files section ok * owns all directories it creates * requires d-bus for one folder - buildrequires/requires ok - builds in koji http://koji.fedoraproject.org/koji/taskinfo?taskID=1882908 - noarch not possible - no *.la files - no shared libs - %doc ok Needswork: - URL still wrong, see comment #1 - from https://fedoraproject.org/wiki/Packaging/Guidelines#Libexecdir 'Packagers are highly encouraged to store libexecdir files in a package-specific subdirectory of %{_libexecdir}, such as %{_libexecdir}/%{name}' - What's the status of the xslt script? ############################ Please fix the url; subdirectory of %{_libexecdir} and 'Is programm working as expected?' are just 'should' items. ############################ APPROVED Thanks for the review. I've fixed the url in the package that I am going to import.. New Package CVS Request ======================= Package Name: at-spi2-core Short Description: Protocol definitions and daemon for D-Bus at-spi Owners: mclasen Branches: InitialCC: CVS Done Build done. |