Bug 574743
Summary: | NameError: global name 'request' is not defined | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | James Laska <jlaska> | ||||||
Component: | anaconda | Assignee: | David Lehman <dlehman> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 13 | CC: | clydekunkel7734, dmalcolm, dzrudy, jonathan, jturner, vanmeeuwen+fedora | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | x86_64 | ||||||||
OS: | Linux | ||||||||
Whiteboard: | anaconda_trace_hash:dbd5d7e27bbd79af6e4757596087d7cb71c4aa18702145bce32f9d7b47a91315 | ||||||||
Fixed In Version: | anaconda-13.37-1.fc13 | Doc Type: | Bug Fix | ||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2010-03-27 04:54:02 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 576529 | ||||||||
Bug Blocks: | 538274 | ||||||||
Attachments: |
|
Description
James Laska
2010-03-18 12:20:05 UTC
Created attachment 400999 [details]
Attached traceback automatically from anaconda.
= steps to reproduce = 1. Install F-12 with encrypted logical volumes for '/' and '/home' 2. Attempt install of F-13-Beta-TC0 using the following partition selections * Re-use existing encrypted logical volume '/home' * Re-use and format existing logical volume 'swap' * Create a new encrypted logical volume for '/' I believe this falls under the Final release criteria [1] point #5 "The installer must be able to create and install to any workable partition layout using any file system offered in a default installer configuration, LVM, software, hardware or BIOS RAID, or combination of the above" However, until we can determine whether this bug affects *all* lvm installs, I'm requesting this a F13Beta blocker. [1] https://fedoraproject.org/wiki/Fedora_13_Final_Release_Criteria I can work around this traceback with the following change, but I'm not sure if it's the *correct* change. --- iw/lvm_dialog_gui.py 2010-03-18 08:49:27.000000000 -0400 +++ /tmp/updates/iw/lvm_dialog_gui.py 2010-03-18 08:40:20.598118902 -0400 @@ -1136,7 +1136,7 @@ # pretty much impossible to be sure we cancelled them # in the correct order. make sure things are back to # their original state. - origlv.format = request.originalFormat + origlv.format = self.vg.format if origlv.format.type == "luks": try: usedev = devicetree.getChildren(origlv)[0] I think the patch in comment#3 is an adjustment to the commit http://git.fedorahosted.org/git/?p=anaconda.git;a=commit;h=fcd6820064d924464d07d3151ff4e503b8591df2 Reviewed during 2010-03-19 F13Beta blocker review. The group agreed this bug was a valid Beta blocker and should be considered for F13-Beta. pylint detects this error (using grep "^E:" to show only errors; it's possible to write a config file to get it to shut up about all the non-PEP8-isms), note the error reported in line 1139 below: [david@surprise anaconda-14.0]$ pylint iw/lvm_dialog_gui.py|grep '^E:' No config file found, using default configuration Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.RuntimeError'> ignored Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.RuntimeError'> ignored E:283:VolumeGroupEditor.clickCB: Instance of 'WideCheckList' has no 'get_model' member E:351:VolumeGroupEditor.createAllowedLvmPartitionsList: Instance of 'WideCheckList' has no 'append_row' member E:368:VolumeGroupEditor.updateAllowedLvmPartitionsList: Instance of 'WideCheckList' has no 'store' member E:369:VolumeGroupEditor.updateAllowedLvmPartitionsList: Instance of 'WideCheckList' has no 'store' member Exception RuntimeError: 'maximum recursion depth exceeded while calling a Python object' in <type 'exceptions.RuntimeError'> ignored E:500:VolumeGroupEditor.editLogicalVolume.<lambda>: Using variable 'maintable' before assignment E:566:VolumeGroupEditor.editLogicalVolume: Class 'vbox' has no 'pack_start' member E:878:VolumeGroupEditor.getSelectedPhysicalVolumes: Instance of 'WideCheckList' has no 'get_model' member E:1139:VolumeGroupEditor.convertToActions: Undefined variable 'request' E:1458:VolumeGroupEditor.__init__: Class 'vbox' has no 'pack_start' member (this is with cvs-dist/anaconda/devel: anaconda-14.0.tar.bz2) *** Bug 575463 has been marked as a duplicate of this bug. *** Updated image available for testing - http://dlehman.fedorapeople.org/updates-574743.img (In reply to comment #8) > Updated image available for testing - > http://dlehman.fedorapeople.org/updates-574743.img Using the updates.img noted earlier, I do not get a traceback, but the installer doesn't seem to let me add a mount point to an existing LVM logical volume. See before (http://jlaska.fedorapeople.org/Screenshot-1.png) and after (http://jlaska.fedorapeople.org/Screenshot-2.png) Created attachment 401829 [details] anacdump.txt (using updates-574743.img) (In reply to comment #9) > (In reply to comment #8) > > Updated image available for testing - > > http://dlehman.fedorapeople.org/updates-574743.img > > Using the updates.img noted earlier, I do not get a traceback, but the > installer doesn't seem to let me add a mount point to an existing LVM logical > volume. > > See before (http://jlaska.fedorapeople.org/Screenshot-1.png) and after > (http://jlaska.fedorapeople.org/Screenshot-2.png) Additionally, I get the attached traceback while attempting to create a new logical volume using the provided updates.img *** Bug 576038 has been marked as a duplicate of this bug. *** No longer experiencing this failure when using the revised updates.img (http://dlehman.fedorapeople.org/updates-576529.img) anaconda-13.37-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/anaconda-13.37-1.fc13 anaconda-13.37-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |