Bug 612241
Summary: | Review Request: telepathy-logger - Telepathy framework logging daemon | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Brian Pepple <bdpepple> |
Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, mclasen, notting |
Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-07-09 18:41:32 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Brian Pepple
2010-07-07 16:09:05 UTC
Builds fine in mock. rpmlint output: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm telepathy-logger.src: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged telepathy-logger.src: W: spelling-error %description -l en_US backends -> backbends, back ends, back-ends telepathy-logger.src:19: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 19) telepathy-logger.x86_64: W: spelling-error %description -l en_US pluggable -> plug gable, plug-gable, plugged telepathy-logger.x86_64: W: spelling-error %description -l en_US backends -> backbends, back ends, back-ends telepathy-logger.x86_64: E: binary-or-shlib-defines-rpath /usr/libexec/telepathy-logger ['/usr/lib64'] telepathy-logger.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/telepathy-logger.schemas telepathy-logger.x86_64: W: dangerous-command-in-%pre rm telepathy-logger.x86_64: W: dangerous-command-in-%post rm 4 packages and 0 specfiles checked; 1 errors, 8 warnings. Looks like all the rpmlint warnings are ignorable, except for the rpath. Some minor cleanups possible: BuildRoot is not longer needed rm -rf $RPM_BUILD_ROOT in %install is no longer needed %clean is no longer needed Ah, forgot to run rpmlint on an x86_64 binary. I'll go ahead and clean up the changes you mentioned and upload a new version tomorrow. Thanks for taking the time to look at this, Matthias! Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-logger.spec SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-logger-0.1.3-2.fc13.src.rpm * Wed Jul 7 2010 Brian Pepple <bpepple> - 0.1.3-2 - Remove unnecessary buildroot info. - Remove rpath. package name: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec file language: ok spec file readable: yes upstream sources: ok buildable: yes excludearch: ok buildrequires: ok locale handling: ok shared libs: ok system libs: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok macro use: ok permissible content: ok large docs: ok %doc content: ok header files: ok static libs: ok shared libs: ok devel deps: ok libtool: ok gui apps: ok file ownership: ok utf8 filenames: ok Approved New Package CVS Request ======================= Package Name: telepathy-logger Short Description: Telepathy framework logging daemon Owners: bpepple Branches: InitialCC: CVS done (by process-cvs-requests.py). Imported & built for devel. Matthias, thanks again for the review. |