Bug 720976
| Summary: | Provide native systemd unit file | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jóhann B. Guðmundsson <johannbg> | ||||||||
| Component: | krb5 | Assignee: | Nalin Dahyabhai <nalin> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | hhorak, k.georgiou, nalin | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | krb5-1.9.1-15.fc16 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2011-10-11 03:15:10 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 740393 | ||||||||||
| Bug Blocks: | 713562 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Jóhann B. Guðmundsson
2011-07-13 11:44:32 UTC
Created attachment 512639 [details]
Native systemd service file kprop
Created attachment 512640 [details]
Native systemd service file kadmin
Created attachment 512641 [details] Native systemd service file krb5kdc This unit files should be a enough to get the ball rolling on this one.. https://fedoraproject.org/wiki/Packaging:Guidelines:Systemd https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd https://fedoraproject.org/wiki/Packaging:Tmpfiles.d krb5-1.9.1-13.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/krb5-1.9.1-13.fc16 Package krb5-1.9.1-13.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing krb5-1.9.1-13.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/krb5-1.9.1-13.fc16 then log in and leave karma (feedback). The unit files appear to have replaced
${KRB5REALM:+-r $KRB5REALM}
with
-r ${KRB5REALM}
which makes the value mandatory where it was optional before. This isn't the desired effect (the default is to pick up the default_realm setting from krb5.conf, and this was an optional way to override that), and since the -r flag can be added to $KRB5KDC_FLAGS, I think it's better dropped.
As noted in bug #740393, the pid file in krb5kdc.systemd is listed as a relative path, which systemd rejects. The ExecStart line also references an undefined $pidfile variable.
The conversion for kadmind currently regresses bug #723723, which is quite understandable due to the timing of when these two bugs were opened. It also requires kpropd.acl to be around, when it's not expected to be there on master KDCs. This is changed to a negated check ("|"->"!") in the update, which brings it more in line with what I'd expect.
The conversion for kprop is missing Type=forking, which causes systemd to assume "Type=simple", and the update replaces ConditionPathExists=| with ConditionPathExists=!, which has a different effect. I'm not really convinced that we need to trigger based on the presence of an ACL file, but the candidate update is getting it wrong.
krb5-1.9.1-14.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/krb5-1.9.1-14.fc16 krb5-1.9.1-15.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/krb5-1.9.1-15.fc16 krb5-1.9.1-15.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. (In reply to comment #9) > krb5-1.9.1-15.fc16 has been pushed to the Fedora 16 stable repository. If > problems still persist, please make note of it in this bug report. Most of the problems noted in comment #6 weren't fixed by this update. krb5-1.9.1-16.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/krb5-1.9.1-16.fc16 |