Bug 805275
Summary: | configchannel.deployAllSystems() API method deploy files for all configuration channel and not only the given configuration channel | ||
---|---|---|---|
Product: | [Community] Spacewalk | Reporter: | Shannon Hughes <shughes> |
Component: | API | Assignee: | Tomas Lestach <tlestach> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Red Hat Satellite QA List <satqe-list> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 1.8 | CC: | mmello |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-11-01 16:17:28 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 871344 |
Description
Shannon Hughes
2012-03-20 18:55:09 UTC
Created attachment 571504 [details]
deployallsystems patch for specific config channel
attaching a patch for review. patch will allow the deployAllSystems API call to only deploy config files from the channel specified. Noticed the webui is using methods in the ConfigurationManager so created a new method and query to handle channel specific calls from the API vs modifying existing listFileNamesForSystem method.
One concern is the language that is used in our apidocs for deployAllSystems API call. Its a bit vague and leans toward deploying all files from a specific config channel to which a system is subsribed which is the goal of this patch to address. But I imagine there is the possibility that existing users that might be using this API call are accustomed to all config files being deployed. If this is a issue, then maybe a separate API call can be created using the query in this patch.
Thanks Shannon, patch applied with together with checkstyle fixes ... spacewalk.git: 1d8fa162998bbafec1dfc5c702b7580080f9834a The trouble is, the API call fails with a SQLException. So, the patch was probably never tested. spacewalk.git: acfd4be1ffdd104c4235307c57b1978c51c8b60b Moving ON_QA. Packages that address this bugzilla should now be available in yum repos at http://yum.spacewalkproject.org/nightly/ Spacewalk 1.8 has been released: https://fedorahosted.org/spacewalk/wiki/ReleaseNotes18 |