Bug 892382
| Summary: | [PATCH] js miscompiled on armv5 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> | ||||
| Component: | js | Assignee: | Peter Robinson <pbrobinson> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 18 | CC: | jdulaney, pahan, pbrobinson | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-02-01 17:19:15 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 245418, 901840 | ||||||
| Attachments: |
|
||||||
Actually we shouldn't have " -mthumb $MOZ_ARM_VFP_FLAGS" either as they're set by the rpm cflags to our required settings as well. I'll push a modified version of the patch today. I had already applied basicaly the same thing, Peter is is correct, the build does not use -mthumb that part of the files is chosen when you enable thumb optimisations as a build flag js-1.8.5-12.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/js-1.8.5-12.fc18 Package js-1.8.5-12.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing js-1.8.5-12.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-1446/js-1.8.5-12.fc18 then log in and leave karma (feedback). js-1.8.5-12.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. Thank you, guys. |
Created attachment 673567 [details] [PATCH] Fix compiler flags on ARM Description of problem: js build hardcodes -march=armv7-a, which is wrong on non-v7 ARms. Version-Release number of selected component (if applicable): js-1.8.5-11.fc19.armv5tel How reproducible: On a v5 arm: [lkundrak@megalodon ~]$ lscpu Architecture: armv5tel Byte Order: Little Endian CPU(s): 1 On-line CPU(s) list: 0 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 1 [lkundrak@megalodon ~]$ uname -a Linux megalodon 3.7.0-6.fc19.armv5tel.kirkwood #1 Mon Dec 24 10:36:18 EST 2012 armv5tel armv5tel armv5tel GNU/Linux [lkundrak@megalodon ~]$ Steps to Reproduce: 1. Run js Actual results: [root@megalodon lkundrak]# /usr/lib/polkit-1/polkitd Successfully changed to user polkitd Illegal instruction [root@megalodon lkundrak]# exit [lkundrak@megalodon ~]$ js Illegal instruction [lkundrak@megalodon ~]$ Expected results: [root@megalodon lkundrak]# /usr/lib/polkit-1/polkitd Successfully changed to user polkitd 00:31:53.348: Loading rules from directory /etc/polkit-1/rules.d 00:31:53.352: Loading rules from directory /usr/share/polkit-1/rules.d ^C [root@megalodon lkundrak]# exit [lkundrak@megalodon ~]$ js js> trolol typein:1: ReferenceError: trolol is not defined js> Additional info: Fix for the issue is attached.