Bug 963307

Summary: Escape single underscores in spice client foreign menu labels so that they aren't intepreted as hot keys
Product: Red Hat Enterprise Virtualization Manager Reporter: David Jaša <djasa>
Component: ovirt-engine-userportalAssignee: Frantisek Kobzik <fkobzik>
Status: CLOSED CURRENTRELEASE QA Contact: Lukas Svaty <lsvaty>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.2.0CC: bsettle, ecohen, gklein, iheim, mavital, michal.skrivanek, rbalakri, Rhev-m-bugs
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: ovirt-3.5.0-alpha2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 08:29:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1130598    
Bug Blocks: 1142923, 1156165    
Attachments:
Description Flags
Totally readable font on CD none

Description David Jaša 2013-05-15 15:50:18 UTC 
Description of problem:
if an underscore in menu label is encountered, gtk (and AFAIK other GUI toolkits, too) don't display the underscore and convert following character to hotkey that can be triggered with alt+<the_character_following_undersore>.

Given that file names of isos in Change CD dialog can contain virtually any characters and underscores are pretty common, the menu gets somewhat cluttered and not-exactly-well readable.

The underscores can be escaped by doubling them.

Version-Release number of selected component (if applicable):
sf17

How reproducible:
always

Steps to Reproduce:
1. connect to a RHEV-M VM using user portal and browser plugin
2. display CD list in Spice --> Change CD menu
3.
  
Actual results:
underscores are eaten and characters after them become a hotkey, e.g.:
RHEV-toolsSetup_3.2_7.iso
becomes:
RHEV-toolsSetup3.27.iso
with first dot and "7" characters underlined

Expected results:
The iso file name is unchanged

Additional info:
Comment 2 Lukas Svaty 2014-08-19 14:49:39 UTC 
verified in ovirt-rc1 still some weird font make CD test_.__.___._.__.iso
a bit unordinary but still bug is VERIFIED
if someone is bothered by the font issue in WinXP IE8 reopen new bug

adding screenshot of it
Comment 3 Lukas Svaty 2014-08-19 14:50:39 UTC 
Created attachment 928393 [details]
Totally readable font on CD
Comment 4 Omer Frenkel 2015-02-17 08:29:58 UTC 
RHEV-M 3.5.0 has been released