Bug 661832 (kdevelop-pg-qt) - Review Request: kdevelop-pg-qt - A parser generator
Summary: Review Request: kdevelop-pg-qt - A parser generator
Keywords:
Status: CLOSED ERRATA
Alias: kdevelop-pg-qt
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dmitrij S. Kryzhevich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: kdevelop-php
TreeView+ depends on / blocked
 
Reported: 2010-12-09 18:40 UTC by Rex Dieter
Modified: 2011-12-08 18:19 UTC (History)
4 users (show)

Fixed In Version: kdevelop-php-1.1.1-3.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-18 21:31:47 UTC
Type: ---
Embargoed:
kryzhev: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Rex Dieter 2010-12-09 18:40:04 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-pg-qt.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-pg-qt-0.9.0-1.fc13.src.rpm
Description:
KDevelop-PG-Qt is a parser generator written in readable source-code and
generating readable source-code. Its syntax was inspirated by AntLR. It
implements the visitor-pattern and uses the Qt library. That is why it
is ideal to be used in Qt-/KDE-based applications like KDevelop.

Comment 1 Rex Dieter 2010-12-09 18:45:03 UTC
scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2655630

rpmlint *.rpm */*.rpm
kdevelop-pg-qt-devel.noarch: W: no-documentation
kdevelop-pg-qt.x86_64: W: no-manual-page-for-binary kdev-pg-qt
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

Comment 2 Dmitrij S. Kryzhevich 2010-12-10 05:36:08 UTC
Grate. 

review:
====================
Good:

# rpmlint *.rpm
kdevelop-pg-qt.x86_64: W: no-manual-page-for-binary kdev-pg-qt
kdevelop-pg-qt-devel.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

rpmlint output could be ignored (but if somebody would ping upstream about man page...).

* Package is named according to the Package Naming Guidelines .
* Spec file name must matchs the base package %{name}. 
* Package meets the Packaging Guidelines.
Notice: you have in %prep
%setup -q -n kdevelop-pg-qt-%{version}
It is as how %setup -q will run, right?
* The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
* File, containing the text of the license(s) for the package is included in %doc.
* The spec file is written in American English.
* The spec file for the package is legible.
* The sources used to build the package matchs the upstream source with md5 summ 06e25c81cc34a5bddda3091ed3280e71.
* The package successfully compiles and builds into binary rpms on x86_64.
* All build dependencies are listed in BuildRequires.
* There are no locales.
* There are no shared libraries.
* Packages does not bundle copies of system libraries.
Notice. Package use part of astyle project, which is not a library.
* Not a relocatable package.
* Package owns all directories that it creates.
* Package must not list a file more than once in the spec file's %files listings.
* Permissions on files are set properly.
* Package uses macros consistently.
* The package contains code.
* There are no documentation.
* Everyting included as %doc does not affect the runtime of the application.
* Header files are in a -devel package.
* There are no static libraries.
* Devel package requires the base package in proper way.
* Not a GUI application.
* Package does not own files or directories already owned by other packages.
* All filenames in rpm packages are valid UTF-8.

Should items:
* Package boukds in mock.
* Package function as described.
* cmake file in -devel subpackage.

==========================================
Not good:

- The License field in the package spec file does not match the actual license.
There are files licensed as GPLv.2+.

Comment 3 Dmitrij S. Kryzhevich 2010-12-10 05:40:51 UTC
One more notice.
For Fedora-only, not EPEL, you not need any more:
- Buildroot tag.[1]
- rm of buildroot in begin of %install.
- %clean section.[2]

[1] https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[2] https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean

Comment 4 Rex Dieter 2010-12-10 17:21:20 UTC
Re: licensing

Using licensecheck (from kdesdk),

$ find kdevelop-pg-qt-0.9.0/kdev-pg -print | xargs licensecheck | grep -v LGPL | sort | uniq
./kdev-pg-lexer.cc: *No copyright* GENERATED FILE
./kdev-pg-parser.cc: GPL 
./kdev-pg-parser.hh: GPL 
./test/test.sh: *No copyright* UNKNOWN

Looks like kdev-pg-parser.* are generated from bison, and is really GPLv2+ indeed , ugh.

Comment 5 Rex Dieter 2010-12-10 17:39:31 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-pg-qt.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-pg-qt-0.9.0-2.fc13.src.rpm

%changelog
* Fri Dec 10 2010 Rex Dieter <rdieter> -  0.9.0-2
- License: GPLv2+

Comment 6 Rex Dieter 2010-12-10 18:39:49 UTC
Posted query to kdevelop-devel mailing list asking for licensing clarification in the meantime.

Comment 7 Kevin Kofler 2010-12-10 20:32:34 UTC
Bison-generated code has an exception so the Bison output can be used by programs under any license, look at the license header carefully.

So this is really:
License: LGPLv2+ and GPLv2+ with exceptions
and can be used in a very similar way to code which is just LGPLv2+ (but the licenses are technically not convertible one to the other, just linkable together or convertible to GPLv2+, so I think you should list both).

Comment 8 Kevin Kofler 2010-12-10 20:35:10 UTC
This is the full text of the exception:
/* As a special exception, you may create a larger work that contains
   part or all of the Bison parser skeleton and distribute that work
   under terms of your choice, so long as that work isn't itself a
   parser generator using the skeleton or a modified version thereof
   as a parser skeleton.  Alternatively, if you modify or redistribute
   the parser skeleton itself, you may (at your option) remove this
   special exception, which will cause the skeleton and the resulting
   Bison output files to be licensed under the GNU General Public
   License without this special exception.
   
   This special exception was added by the Free Software Foundation in
   version 2.2 of Bison.  */

Comment 9 Dmitrij S. Kryzhevich 2010-12-13 05:11:13 UTC
(In reply to comment #5)
> %changelog
> * Fri Dec 10 2010 Rex Dieter <rdieter> -  0.9.0-2
> - License: GPLv2+

The *main* license is LGPL, you mark this by yourself ("# All LGPLv2+, except for bison-generated..."). So, as Kevin wrote, it should be
License: LGPLv2+ and GPLv2+ with exception

Comment 10 Rex Dieter 2010-12-14 16:58:29 UTC
Spec URL: http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-pg-qt.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdevelop-php/kdevelop-pg-qt-0.9.0-3.fc14.src.rpm

%changelog
* Thu Dec 14 2010 Rex Dieter <rdieter> - 0.9.0-3
- License: LGPLv2+ and GPLv2+ with exception

Comment 11 Dmitrij S. Kryzhevich 2010-12-15 04:54:38 UTC
==========
APPROVED
==========

Comment 12 Rex Dieter 2010-12-15 15:13:17 UTC
New Package SCM Request
=======================
Package Name: kdevelop-pg-qt
Short Description: A parser generator
Owners: rdieter,than,ltinkl,thomasj,kkofler
Branches: f13,f14
InitialCC: rnovacek,tuxbrewr

Comment 13 Jason Tibbitts 2010-12-15 15:31:11 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2011-01-05 20:07:27 UTC
kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14

Comment 15 Fedora Update System 2011-01-05 20:07:56 UTC
kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc13,kdevelop-pg-qt-0.9.0-3.fc13

Comment 16 Fedora Update System 2011-01-06 19:23:35 UTC
kdevelop-php-1.1.1-3.fc14, kdevelop-pg-qt-0.9.0-3.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kdevelop-php kdevelop-pg-qt'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/kdevelop-php-1.1.1-3.fc14,kdevelop-pg-qt-0.9.0-3.fc14

Comment 17 Fedora Update System 2011-01-18 21:31:36 UTC
kdevelop-php-1.1.1-3.fc14, kdevelop-pg-qt-0.9.0-3.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2011-01-18 21:38:11 UTC
kdevelop-php-1.1.1-3.fc13, kdevelop-pg-qt-0.9.0-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.