Attachment 1019303 Details for Bug 1208369 – Proposed patch fixing signed integer overflow in type.cpp

[patch] Proposed patch fixing signed integer overflow in type.cpp

rhbz1208369_signed_int_long_overflow_type.cpp.patch (text/plain), 1.62 KB, created by Severin Gehwolf on 2015-04-27 12:03:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Severin Gehwolf

Created: 2015-04-27 12:03:06 UTC

Size: 1.62 KB

patch

obsolete

>diff --git a/src/share/vm/opto/type.cpp b/src/share/vm/opto/type.cpp
>--- jdk8/hotspot/src/share/vm/opto/type.cpp
>+++ jdk8/hotspot/src/share/vm/opto/type.cpp
>@@ -1158,11 +1158,11 @@
>   // Certain normalizations keep us sane when comparing types.
>   // The 'SMALLINT' covers constants and also CC and its relatives.
>   if (lo <= hi) {
>-    if ((juint)(hi - lo) <= SMALLINT)  w = Type::WidenMin;
>-    if ((juint)(hi - lo) >= max_juint) w = Type::WidenMax; // TypeInt::INT
>+    if ((juint)hi - lo <= SMALLINT)  w = Type::WidenMin;
>+    if ((juint)hi - lo >= max_juint) w = Type::WidenMax; // TypeInt::INT
>   } else {
>-    if ((juint)(lo - hi) <= SMALLINT)  w = Type::WidenMin;
>-    if ((juint)(lo - hi) >= max_juint) w = Type::WidenMin; // dual TypeInt::INT
>+    if ((juint)lo - hi <= SMALLINT)  w = Type::WidenMin;
>+    if ((juint)lo - hi >= max_juint) w = Type::WidenMin; // dual TypeInt::INT
>   }
>   return w;
> }
>@@ -1416,11 +1416,11 @@
>   // Certain normalizations keep us sane when comparing types.
>   // The 'SMALLINT' covers constants.
>   if (lo <= hi) {
>-    if ((julong)(hi - lo) <= SMALLINT)   w = Type::WidenMin;
>-    if ((julong)(hi - lo) >= max_julong) w = Type::WidenMax; // TypeLong::LONG
>+    if ((julong)hi - lo <= SMALLINT)   w = Type::WidenMin;
>+    if ((julong)hi - lo >= max_julong) w = Type::WidenMax; // TypeLong::LONG
>   } else {
>-    if ((julong)(lo - hi) <= SMALLINT)   w = Type::WidenMin;
>-    if ((julong)(lo - hi) >= max_julong) w = Type::WidenMin; // dual TypeLong::LONG
>+    if ((julong)lo - hi <= SMALLINT)   w = Type::WidenMin;
>+    if ((julong)lo - hi >= max_julong) w = Type::WidenMin; // dual TypeLong::LONG
>   }
>   return w;
> }

Actions: View | Diff

Attachments on bug 1208369: 1010090 | 1014401 | 1015629 | 1019303