Attachment 105341 Details for Bug 135202 – hoplug sequence number patch in lib/kobject.c that greatly reduces gaps in hotplug seqnums

[patch] hoplug sequence number patch in lib/kobject.c that greatly reduces gaps in hotplug seqnums

linux-2.6.9-kobject.patch (text/plain), 1.03 KB, created by Andrew Duggan on 2004-10-17 04:06:25 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Duggan

Created: 2004-10-17 04:06:25 UTC

Size: 1.03 KB

patch

obsolete

>diff -Nru a/lib/kobject.c b/lib/kobject.c
>--- a/lib/kobject.c	2004-10-16 17:06:06.897580773 -0400
>+++ b/lib/kobject.c	2004-10-16 17:08:05.794414613 -0400
>@@ -177,6 +177,10 @@
> 	envp [i++] = scratch;
> 	scratch += sprintf(scratch, "ACTION=%s", action) + 1;
> 
>+	kobj_path = kobject_get_path(kset, kobj, GFP_KERNEL);
>+	if (!kobj_path)
>+		goto exit;
>+
> 	spin_lock(&sequence_lock);
> 	seq = sequence_num++;
> 	spin_unlock(&sequence_lock);
>@@ -184,10 +188,6 @@
> 	envp [i++] = scratch;
> 	scratch += sprintf(scratch, "SEQNUM=%ld", seq) + 1;
> 
>-	kobj_path = kobject_get_path(kset, kobj, GFP_KERNEL);
>-	if (!kobj_path)
>-		goto exit;
>-
> 	envp [i++] = scratch;
> 	scratch += sprintf (scratch, "DEVPATH=%s", kobj_path) + 1;
> 
>@@ -199,6 +199,13 @@
> 		if (retval) {
> 			pr_debug ("%s - hotplug() returned %d\n",
> 				  __FUNCTION__, retval);
>+			/* decr sequence_num since no event will happen
>+			   but only if it is consistent */
>+			spin_lock(&sequence_lock);
>+			if (sequence_num == seq+1)
>+			   sequence_num--;
>+			spin_unlock(&sequence_lock);
>+
> 			goto exit;
> 		}
> 	}

Actions: View | Diff

Attachments on bug 135202: 104979 | 104980 | 104981 | 105002 | 105003 | 105004 | 105006 | 105264 | 105265 | 105266 | 105267 | 105341 | 105412