Login
Log in using an SSO provider:
Fedora Account System
Red Hat Associate
Red Hat Customer
Login using a Red Hat Bugzilla account
Forgot Password
Create an Account
Red Hat Bugzilla – Attachment 1081764 Details for
Bug 1267233
Review Request: php-sebastian-resource-operations - Provides a list of PHP built-in functions that operate on resources
Home
New
Search
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh109 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
Migrated Products
[?]
This site requires JavaScript to be enabled to function correctly, please enable it.
fedora-review.txt
review.txt (text/plain), 7.10 KB, created by
Shawn Iwinski
on 2015-10-11 05:54:06 UTC
(
hide
)
Description:
fedora-review.txt
Filename:
MIME Type:
Creator:
Shawn Iwinski
Created:
2015-10-11 05:54:06 UTC
Size:
7.10 KB
patch
obsolete
>Package Review >============== > >Legend: >[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated >[ ] = Manual review needed > > > >===== MUST items ===== > >Generic: >[x]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. >[x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated". 3 files have unknown license. >[x]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: > /usr/share/php/SebastianBergmann(php-sebastian-global-state, php- > sebastian-recursion-context, php-phpunit-Version, php-phpunit- > environment, php-phpunit-diff) > > Mentioned packages are not requirements of this package so this package > must own the mentioned directory. > >[x]: Package contains no bundled libraries without FPC exception. >[x]: Changelog in prescribed format. >[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Note: rm -rf %{buildroot} present but not required >[x]: Sources contain only permissible code or content. >[!]: Each %files section contains %defattr if rpm < 4.4 > Note: %defattr present but not needed >[-]: Package contains desktop file if it is a GUI application. >[-]: Development files must be in a -devel package >[x]: Package uses nothing in %doc for runtime. >[x]: Package consistently uses macros (instead of hard-coded directory > names). >[x]: Package is named according to the Package Naming Guidelines. >[x]: Package does not generate any conflict. >[x]: Package obeys FHS, except libexecdir and /usr/target. >[-]: If the package is a rename of another package, proper Obsoletes and > Provides are present. >[x]: Requires correct, justified where necessary. >[x]: Spec file is legible and written in American English. >[-]: Package contains systemd file(s) if in need. >[x]: Package is not known to require an ExcludeArch tag. >[x]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 10240 bytes in 2 files. >[x]: Package complies to the Packaging Guidelines >[x]: Package successfully compiles and builds into binary rpms on at least > one supported primary architecture. >[x]: Package installs properly. >[x]: Rpmlint is run on all rpms the build produces. > Note: No rpmlint messages. >[x]: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %license. >[x]: Package requires other packages for directories it uses. >[x]: Package must own all directories that it creates. >[x]: All build dependencies are listed in BuildRequires, except for any > that are listed in the exceptions section of Packaging Guidelines. >[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT >[x]: Macros in Summary, %description expandable at SRPM build time. >[x]: Dist tag is present. >[x]: Package does not contain duplicates in %files. >[x]: Permissions on files are set properly. >[x]: Package use %makeinstall only when make install DESTDIR=... doesn't > work. >[x]: Package is named using only allowed ASCII characters. >[x]: Package does not use a name that already exists. >[x]: Package is not relocatable. >[x]: Sources used to build the package match the upstream source, as > provided in the spec URL. >[x]: Spec file name must match the spec package %{name}, in the format > %{name}.spec. >[x]: File names are valid UTF-8. >[x]: Packages must not store files under /srv, /opt or /usr/local > >===== SHOULD items ===== > >Generic: >[!]: Buildroot is not present > Note: Buildroot: present but not needed >[!]: Package has no %clean section with rm -rf %{buildroot} (or > $RPM_BUILD_ROOT) > Note: %clean present but not required >[-]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. >[x]: Final provides and requires are sane (see attachments). >[x]: Package functions as described. >[x]: Latest version is packaged. >[x]: Package does not include license text files separate from upstream. >[-]: Description and summary sections in the package spec file contains > translations for supported Non-English languages, if available. >[x]: Package should compile and build into binary rpms on all supported > architectures. >[x]: %check is present and all tests pass. >[x]: Packages should try to preserve timestamps of original installed > files. >[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file >[x]: Sources can be downloaded from URI in Source: tag >[x]: Reviewer should test that the package builds in mock. >[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. >[x]: SourceX is a working URL. >[x]: Spec use %global instead of %define unless justified. > >===== EXTRA items ===== > >Generic: >[x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). >[x]: Spec file according to URL is the same as in SRPM. > >PHP: >[x]: Run phpci static analyze on all php files. > Note: phpCompatInfo version 4.4.0 DB built Jul 20 2015 15:06:38 CEST > > >Rpmlint >------- >Checking: php-sebastian-resource-operations-1.0.0-1.fc24.noarch.rpm > php-sebastian-resource-operations-1.0.0-1.fc24.src.rpm >2 packages and 0 specfiles checked; 0 errors, 0 warnings. > > > > >Rpmlint (installed packages) >---------------------------- >sh: /usr/bin/python: No such file or directory >php-sebastian-resource-operations.noarch: W: invalid-url URL: https://github.com/sebastianbergmann/resource-operations <urlopen error [Errno -5] No address associated with hostname> >1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > > >Requires >-------- >php-sebastian-resource-operations (rpmlib, GLIBC filtered): > php(language) > > > >Provides >-------- >php-sebastian-resource-operations: > php-composer(sebastian/resource-operations) > php-sebastian-resource-operations > > > >Source checksums >---------------- >https://github.com/sebastianbergmann/resource-operations/archive/ce990bb21759f94aeafd30209e8cfcdfa8bc3f52/resource-operations-1.0.0-ce990bb.tar.gz : > CHECKSUM(SHA256) this package : 2031aa7e2dc67c29be0695c7572562f9205a2843f50be4bccf7062e3f595f500 > CHECKSUM(SHA256) upstream package : 2031aa7e2dc67c29be0695c7572562f9205a2843f50be4bccf7062e3f595f500 >https://raw.githubusercontent.com/remicollet/resource-operations/issue-tests/tests/ResourceOperationsTest.php : > CHECKSUM(SHA256) this package : 5d64825b3fdc25a223443939592e0b45c1bc479cce30d37bb9f98181e4ddc974 > CHECKSUM(SHA256) upstream package : 5d64825b3fdc25a223443939592e0b45c1bc479cce30d37bb9f98181e4ddc974 > > >Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 >Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1267233 >Buildroot used: fedora-rawhide-x86_64 >Active plugins: Generic, PHP, Shell-api >Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby >Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 1267233
:
1081762
|
1081763
| 1081764