Attachment 1106537 Details for Bug 1290924 – review.txt

review.txt

review.txt (text/plain), 8.45 KB, created by Raphael Groner on 2015-12-16 21:46:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Raphael Groner

Created: 2015-12-16 21:46:59 UTC

Size: 8.45 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>- Package installs properly.
>  Note: Installation errors (see attachment)
>  See: https://fedoraproject.org/wiki/Packaging:Guidelines
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses
>     found: "GPL", "Unknown or generated". 27 files have unknown license.
>     Detailed output of licensecheck in /home/builder/fedora-
>     review/1290924-grive2/licensecheck.txt
>[x]: License file installed when any subpackage combination is installed.
>[x]: %build honors applicable compiler flags or justifies otherwise.
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Useful -debuginfo package or justification otherwise.
>[x]: Package is not known to require an ExcludeArch tag.
>[-]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 10240 bytes in 1 files.
>[x]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least
>     one supported primary architecture.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>[x]: If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %license.
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Dist tag is present.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package does not use a name that already exists.
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[-]: If the source package does not include license text(s) as a separate
>     file from upstream, the packager SHOULD query upstream to include it.
>[x]: Final provides and requires are sane (see attachments).
>[?]: Fully versioned dependency in subpackages if applicable.
>     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
>     grive2-debuginfo
>[?]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed
>     files.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: Sources can be downloaded from URI in Source: tag
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Uses parallel make %{?_smp_mflags} macro.
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[!]: Rpmlint is run on all installed packages.
>     Note: Mock build failed
>     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
>=> IGNORE
>[x]: Large data in /usr/share should live in a noarch subpackage if package
>     is arched.
>[x]: Spec file according to URL is the same as in SRPM.
>
>
>Installation errors
>-------------------
>INFO: mock.py version 1.2.14 starting (python version = 3.4.3)...
>Start: init plugins
>INFO: selinux enabled
>Finish: init plugins
>Start: run
>Start: chroot init
>INFO: calling preinit hooks
>INFO: enabled root cache
>INFO: enabled dnf cache
>Start: cleaning dnf metadata
>Finish: cleaning dnf metadata
>INFO: enabled ccache
>Mock Version: 1.2.14
>INFO: Mock Version: 1.2.14
>Finish: chroot init
>INFO: installing package(s): /home/builder/fedora-review/1290924-grive2/results/grive2-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm /home/builder/fedora-review/1290924-grive2/results/grive2-debuginfo-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm /home/builder/fedora-review/1290924-grive2/results/grive2-debuginfo-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm
>ERROR: Command failed. See logs for output.
> # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 24 --setopt=deltarpm=false install /home/builder/fedora-review/1290924-grive2/results/grive2-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm /home/builder/fedora-review/1290924-grive2/results/grive2-debuginfo-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm /home/builder/fedora-review/1290924-grive2/results/grive2-debuginfo-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm --setopt=tsflags=nocontexts
>
>
>Rpmlint
>-------
>Checking: grive2-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm
>          grive2-debuginfo-0.4.2-0.1.20151208gitcc13b8b.fc24.x86_64.rpm
>          grive2-0.4.2-0.1.20151208gitcc13b8b.fc24.src.rpm
>3 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>
>
>Requires
>--------
>grive2 (rpmlib, GLIBC filtered):
>    libboost_filesystem.so.1.59.0()(64bit)
>    libboost_program_options.so.1.59.0()(64bit)
>    libboost_regex.so.1.59.0()(64bit)
>    libboost_system.so.1.59.0()(64bit)
>    libboost_unit_test_framework.so.1.59.0()(64bit)
>    libc.so.6()(64bit)
>    libcurl.so.4()(64bit)
>    libdl.so.2()(64bit)
>    libexpat.so.1()(64bit)
>    libgcc_s.so.1()(64bit)
>    libgcc_s.so.1(GCC_3.0)(64bit)
>    libgcrypt.so.20()(64bit)
>    libgcrypt.so.20(GCRYPT_1.6)(64bit)
>    libgpg-error.so.0()(64bit)
>    libm.so.6()(64bit)
>    libstdc++.so.6()(64bit)
>    libstdc++.so.6(CXXABI_1.3)(64bit)
>    libyajl.so.2()(64bit)
>    libz.so.1()(64bit)
>    rtld(GNU_HASH)
>
>grive2-debuginfo (rpmlib, GLIBC filtered):
>
>
>
>Provides
>--------
>grive2:
>    grive2
>    grive2(x86-64)
>
>grive2-debuginfo:
>    grive2-debuginfo
>    grive2-debuginfo(x86-64)
>
>
>
>Source checksums
>----------------
>https://github.com/vitalif/grive2/archive/cc13b8b34300e4b309a95d983a2cbb363a0d0076.tar.gz#/grive2-cc13b8b34300e4b309a95d983a2cbb363a0d0076.tar.gz :
>  CHECKSUM(SHA256) this package     : 61f07ee62eac82ec4ee1615d1d93e7493d36bcbcab707e8d3198acaaeeed49e3
>  CHECKSUM(SHA256) upstream package : 61f07ee62eac82ec4ee1615d1d93e7493d36bcbcab707e8d3198acaaeeed49e3
>
>
>Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20
>Command line :/usr/bin/fedora-review -v -m fedora-rawhide-x86_64 -b 1290924
>Buildroot used: fedora-rawhide-x86_64
>Active plugins: Generic, Shell-api
>Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
>Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Actions: View

Attachments on bug 1290924: 1106537 | 1106538