Login
Log in using an SSO provider:
Fedora Account System
Red Hat Associate
Red Hat Customer
Login using a Red Hat Bugzilla account
Forgot Password
Create an Account
Red Hat Bugzilla – Attachment 114790 Details for
Bug 156840
(gcc4 _FORTIFY_SOURCE=2) perl-DBD-pg Placeholders no longer functioning
Home
New
Search
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh92 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
[?]
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Eliminates the problem exposed by _FORTIFY_SOURCE=2
perl-DBD-Pg-1.41-gcc4-fortify-source.patch (text/plain), 838 bytes, created by
Jose Pedro Oliveira
on 2005-05-24 18:24:52 UTC
(
hide
)
Description:
Eliminates the problem exposed by _FORTIFY_SOURCE=2
Filename:
MIME Type:
Creator:
Jose Pedro Oliveira
Created:
2005-05-24 18:24:52 UTC
Size:
838 bytes
patch
obsolete
>diff -ruN DBD-Pg-1.41-orig/dbdimp.c DBD-Pg-1.41/dbdimp.c >--- DBD-Pg-1.41-orig/dbdimp.c 2005-04-06 21:40:20.000000000 +0100 >+++ DBD-Pg-1.41/dbdimp.c 2005-05-24 17:57:20.000000000 +0100 >@@ -1167,6 +1167,9 @@ > unsigned int params = 0; > Oid *paramTypes = NULL; > ph_t *currph; >+#define TMPBUF_MAX_SIZE 16 >+ char tmpbuf[TMPBUF_MAX_SIZE]; >+ int tmpres; > > #if PGLIBVERSION >= 80000 > oldprepare = 0; >@@ -1243,7 +1246,11 @@ > for (currseg=imp_sth->seg; NULL != currseg; currseg=currseg->nextseg) { > strcat(statement, currseg->segment); > if (currseg->placeholder) { >- sprintf(statement, "%s$%d", statement, currseg->placeholder); >+ tmpres = snprintf(tmpbuf, TMPBUF_MAX_SIZE, "$%d", currseg->placeholder); >+ if (tmpres >= TMPBUF_MAX_SIZE) { >+ croak("Placeholder truncated"); >+ } >+ strncat(statement, tmpbuf, tmpres); > } > } >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=114790">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 156840
:
114790
|
114791
|
116072