Attachment 1197056 Details for Bug 1372252 – Patch which can resolve the observed issue

[patch] Patch which can resolve the observed issue

0001-arm64-kexec-use-phys_to_virt-in-stead-of-kmap.patch (text/plain), 1.56 KB, created by Pratyush Anand on 2016-09-02 07:09:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pratyush Anand

Created: 2016-09-02 07:09:34 UTC

Size: 1.56 KB

patch

obsolete

>From a19bf158a0f52328522068c48696fcec27125096 Mon Sep 17 00:00:00 2001
>Message-Id: <a19bf158a0f52328522068c48696fcec27125096.1472799913.git.panand@redhat.com>
>From: Pratyush Anand <panand@redhat.com>
>Date: Fri, 2 Sep 2016 12:30:52 +0530
>Subject: [PATCH] arm64: kexec: use phys_to_virt() in stead of kmap()
>
>kmap() might sleep, which is not good for a crashed kernel. So use
>phys_to_virt() in stead of kmap() as these regions are in linear mapping
>range.
>
>Signed-off-by: Pratyush Anand <panand@redhat.com>
>---
> arch/arm64/kernel/machine_kexec.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/arch/arm64/kernel/machine_kexec.c b/arch/arm64/kernel/machine_kexec.c
>index a108cf91bb73..2a2dcc91a924 100644
>--- a/arch/arm64/kernel/machine_kexec.c
>+++ b/arch/arm64/kernel/machine_kexec.c
>@@ -120,7 +120,7 @@ static void kexec_list_flush(struct kimage *kimage)
> 	unsigned int flag;
> 
> 	for (entry = &kimage->head, flag = 0; flag != IND_DONE; entry++) {
>-		void *addr = kmap(phys_to_page(*entry & PAGE_MASK));
>+		void *addr = phys_to_virt(*entry & PAGE_MASK);
> 
> 		flag = *entry & IND_FLAGS;
> 
>@@ -139,7 +139,6 @@ static void kexec_list_flush(struct kimage *kimage)
> 		default:
> 			BUG();
> 		}
>-		kunmap(addr);
> 	}
> }
> 
>@@ -178,7 +177,7 @@ void machine_kexec(struct kimage *kimage)
> 	BUG_ON((num_online_cpus() > 1) && !WARN_ON(in_crash_kexec));
> 
> 	reboot_code_buffer_phys = page_to_phys(kimage->control_code_page);
>-	reboot_code_buffer = kmap(kimage->control_code_page);
>+	reboot_code_buffer = phys_to_virt(reboot_code_buffer_phys);
> 
> 	kexec_image_info(kimage);
> 
>-- 
>2.7.4
>

Actions: View | Diff

Attachments on bug 1372252: 1197056