Attachment 125562 Details for Bug 182416 – Preliminary patch, useful to confirm the diagnosis.

[patch] Preliminary patch, useful to confirm the diagnosis.

cairo-xlib-surface-bailout-over-20000-glyphs.patch (text/plain), 1.17 KB, created by Carl Worth (Ampere) on 2006-03-02 19:51:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Carl Worth (Ampere)

Created: 2006-03-02 19:51:13 UTC

Size: 1.17 KB

patch

obsolete

>diff --git a/src/cairo-xlib-surface.c b/src/cairo-xlib-surface.c
>index a62afed..68fe238 100644
>--- a/src/cairo-xlib-surface.c
>+++ b/src/cairo-xlib-surface.c
>@@ -2424,6 +2424,21 @@ _cairo_xlib_surface_old_show_glyphs (cai
> 	(font_private != NULL && font_private->dpy != self->dpy))
> 	return CAIRO_INT_STATUS_UNSUPPORTED;
> 
>+    /* XXX: This 20000 number was arbitrarily picked from the ballpark
>+     * of values that empirically appear to do the job. I'm working on
>+     * coming up with the real equation for deciding this cutoff. */
>+
>+    /* XXX: Returning UNSUPPORTED in this case is not the kindest
>+     * thing to do. The results will still be correct, (the
>+     * UNSUPPORTED return will cause fallbacks to kick in), but there
>+     * will be a rather abrupt performance cliff for any application
>+     * that crosses this threshold. Better would be to still render
>+     * all the glyphs via XRender but just batch it up into
>+     * small-enough pieces. */
>+
>+    if (num_glyphs > 20000)
>+	return CAIRO_INT_STATUS_UNSUPPORTED;
>+
>     status = _cairo_pattern_acquire_surface (pattern, &self->base,
> 					     source_x, source_y, width, height,
> 					     (cairo_surface_t **) &src,

Actions: View | Diff

Attachments on bug 182416: 125028 | 125562 | 125615