Attachment 1255678 Details for Bug 1424015 – skiboot_bypass_fallthrough.patch

[patch] skiboot_bypass_fallthrough.patch

skiboot_bypass_fallthrough.patch (text/plain), 1.85 KB, created by Michel Normand on 2017-02-20 13:03:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michel Normand

Created: 2017-02-20 13:03:37 UTC

Size: 1.85 KB

patch

obsolete

>From: Michel Normand <normand@linux.vnet.ibm.com>
>Subject: skiboot bypass fallthrough
>Date: Mon, 20 Feb 2017 07:15:32 -0500
>
>skiboot avoid Fallthrough errors reported by gcc7
>
>Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
>---
> hw/fsp/fsp-sysparam.c  |    2 +-
> hw/p7ioc-phb.c         |    1 +
> libc/stdio/vsnprintf.c |    1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
>Index: skiboot-skiboot-5.2.0/hw/fsp/fsp-sysparam.c
>===================================================================
>--- skiboot-skiboot-5.2.0.orig/hw/fsp/fsp-sysparam.c
>+++ skiboot-skiboot-5.2.0/hw/fsp/fsp-sysparam.c
>@@ -100,7 +100,7 @@ static int fsp_sysparam_process(struct s
> 	case 0x00: /* XXX Is that even possible ? */
> 	case 0x11: /* Data in request */
> 		memcpy(r->ubuf, &r->resp.data.words[2], len);
>-		/* pass through */
>+		/* Fallthrough */
> 	case 0x12: /* Data in TCE */
> 		stlen = len;
> 		break;
>Index: skiboot-skiboot-5.2.0/hw/p7ioc-phb.c
>===================================================================
>--- skiboot-skiboot-5.2.0.orig/hw/p7ioc-phb.c
>+++ skiboot-skiboot-5.2.0/hw/p7ioc-phb.c
>@@ -470,6 +470,7 @@ static int64_t p7ioc_sm_slot_power_off(s
> 		p->retries = 1000;
> 		p->state = P7IOC_PHB_STATE_SPDOWN_SLOT_STATUS;
> 		PHBDBG(p, "Slot power off: waiting for power off\n");
>+		/* Fallthrough */
> 	case P7IOC_PHB_STATE_SPDOWN_SLOT_STATUS:
> 		reg = in_be64(p->regs + PHB_PCIE_SLOTCTL2);
> 		if (!(reg & PHB_PCIE_SLOTCTL2_PWR_EN_STAT)) {
>Index: skiboot-skiboot-5.2.0/libc/stdio/vsnprintf.c
>===================================================================
>--- skiboot-skiboot-5.2.0.orig/libc/stdio/vsnprintf.c
>+++ skiboot-skiboot-5.2.0/libc/stdio/vsnprintf.c
>@@ -164,6 +164,7 @@ print_format(char **buffer, size_t bufsi
> 				break;
> 			case 'X':
> 				upper = true;
>+				/* Fallthrough */
> 			case 'x':
> 				sizec[i] = '\0';
> 				value = (unsigned long) var & convert[length_mod];

Actions: View | Diff

Attachments on bug 1424015: 1253359 | 1253360 | 1253361 | 1255678