Attachment 1265011 Details for Bug 1389223 – trace-cmd: Fix segmentation fault in trace-snapshot

[patch] trace-cmd: Fix segmentation fault in trace-snapshot

0001-trace-cmd-Fix-segmentation-fault-in-trace-snapshot.patch (text/plain), 1.03 KB, created by John Kacur on 2017-03-21 11:11:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John Kacur

Created: 2017-03-21 11:11:34 UTC

Size: 1.03 KB

patch

obsolete

>From 6087cef5a15b7b7dbbbcc35ec70382ecab615e34 Mon Sep 17 00:00:00 2001
>From: John Kacur <jkacur@redhat.com>
>Date: Tue, 21 Mar 2017 11:26:05 +0100
>Subject: [PATCH] trace-cmd: Fix segmentation fault in trace-snapshot
>
>To reproduce the problem:
>
>  plugin 'wakeup'
>trace-cmd: Device or resource busy
>  Segmentation fault (core dumped)
>
>When the user triggers a condition such as EBUSY the program should die
>gracefully. The problem here is simply caused by an extra conversion
>specifier in "die" in the write_file function
>
>Signed-off-by: John Kacur <jkacur@redhat.com>
>---
> trace-snapshot.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/trace-snapshot.c b/trace-snapshot.c
>index 9d3608c49563..771b065ccfa4 100644
>--- a/trace-snapshot.c
>+++ b/trace-snapshot.c
>@@ -42,7 +42,8 @@ static void write_file(const char *name, char *val)
> 
> 	n = write(fd, val, strlen(val));
> 	if (n < 0)
>-		die("failed to write '%d' to %s\n", path);
>+		die("failed to write to %s\n", path);
>+
> 	tracecmd_put_tracing_file(path);
> 	close(fd);
> }
>-- 
>2.5.5
>

Actions: View | Diff

Attachments on bug 1389223: 1265011