Attachment 1410448 Details for Bug 1553595 – [PATCH] manager: retry activating devices when the parent becomes managed

[patch] [PATCH] manager: retry activating devices when the parent becomes managed

0001-manager-retry-activating-devices-when-the-parent-bec.patch (text/plain), 1.32 KB, created by Beniamino Galvani on 2018-03-20 12:49:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Beniamino Galvani

Created: 2018-03-20 12:49:40 UTC

Size: 1.32 KB

patch

obsolete

>From 6f6d8d6763af7afeb456c12d82b636a00736e658 Mon Sep 17 00:00:00 2001
>From: Beniamino Galvani <bgalvani@redhat.com>
>Date: Mon, 19 Mar 2018 14:15:56 +0100
>Subject: [PATCH] manager: retry activating devices when the parent becomes
> managed
>
>Since commit ed640f857a1a ("manager: ignore unmanaged devices when
>looking for parent by UUID"), unmanaged devices are ignored when
>looking for potential parent connection matches. Therefore, a software
>device can fail autoactivation because the parent is not managed yet
>and NM never tries to reactivate it. Ensure that we retry other
>devices when a parent device becomes managed.
>
>Fixes: ed640f857a1a1eae45d92cce35ea8dcfd8aba08d
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1553595
>---
> src/nm-manager.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/src/nm-manager.c b/src/nm-manager.c
>index 0b34ff44a..74d9d8f98 100644
>--- a/src/nm-manager.c
>+++ b/src/nm-manager.c
>@@ -1193,6 +1193,10 @@ manager_device_state_changed (NMDevice *device,
> 	NMManager *self = NM_MANAGER (user_data);
> 	NMManagerPrivate *priv = NM_MANAGER_GET_PRIVATE (self);
> 
>+	if (   old_state == NM_DEVICE_STATE_UNMANAGED
>+	    && new_state > NM_DEVICE_STATE_UNMANAGED)
>+		retry_connections_for_parent_device (self, device);
>+
> 	switch (new_state) {
> 	case NM_DEVICE_STATE_UNMANAGED:
> 	case NM_DEVICE_STATE_UNAVAILABLE:
>-- 
>2.14.3
>

Actions: View | Diff

Attachments on bug 1553595: 1406158 | 1407102 | 1407413 | 1407568 | 1410448