Attachment 1441039 Details for Bug 1084817 – mark md5 function as not being used for security

[patch] mark md5 function as not being used for security

numpy-1.7.1-md5-FIPS.patch (text/plain), 1.73 KB, created by Nikola Forró on 2018-05-24 12:01:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nikola Forró

Created: 2018-05-24 12:01:36 UTC

Size: 1.73 KB

patch

obsolete

>diff --git a/numpy/core/code_generators/genapi.py b/numpy/core/code_generators/genapi.py
>index 3860fe6..2c0a489 100644
>--- a/numpy/core/code_generators/genapi.py
>+++ b/numpy/core/code_generators/genapi.py
>@@ -108,7 +108,7 @@ class Function(object):
>         return '\n'.join(lines)
> 
>     def api_hash(self):
>-        m = md5new()
>+        m = md5new(usedforsecurity=False)
>         m.update(remove_whitespace(self.return_type))
>         m.update('\000')
>         m.update(self.name)
>@@ -449,7 +449,7 @@ def fullapi_hash(api_dicts):
>             a.extend(name)
>             a.extend(str(index))
> 
>-    return md5new(''.join(a).encode('ascii')).hexdigest()
>+    return md5new(''.join(a).encode('ascii'), usedforsecurity=False).hexdigest()
> 
> # To parse strings like 'hex = checksum' where hex is e.g. 0x1234567F and
> # checksum a 128 bits md5 checksum (hex format as well)
>@@ -474,7 +474,7 @@ def main():
>     tagname = sys.argv[1]
>     order_file = sys.argv[2]
>     functions = get_api_functions(tagname, order_file)
>-    m = md5new(tagname)
>+    m = md5new(tagname, usedforsecurity=False)
>     for func in functions:
>         print(func)
>         ah = func.api_hash()
>diff --git a/numpy/core/tests/test_regression.py b/numpy/core/tests/test_regression.py
>index a3af6b6..06c9b0e 100644
>--- a/numpy/core/tests/test_regression.py
>+++ b/numpy/core/tests/test_regression.py
>@@ -1349,7 +1349,7 @@ class TestRegression(TestCase):
>             from md5 import new as md5
> 
>         x = np.array([1,2,3], dtype=np.dtype('<i4'))
>-        assert_equal(md5(x).hexdigest(), '2a1dd1e1e59d0a384c26951e316cd7e6')
>+        assert_equal(md5(x, usedforsecurity=False).hexdigest(), '2a1dd1e1e59d0a384c26951e316cd7e6')
> 
>     def test_numeric_handleError(self):
>         """Ticket #1405"""

Actions: View | Diff

Attachments on bug 1084817: 1441039 | 1719422