Attachment 1447855 Details for Bug 1573839 – [PATCH] cli: fix array out-of-bounds access on command timeout

[patch] [PATCH] cli: fix array out-of-bounds access on command timeout

0001-cli-fix-array-out-of-bounds-access-on-command-timeou.patch (text/plain), 1.18 KB, created by Beniamino Galvani on 2018-06-05 12:50:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Beniamino Galvani

Created: 2018-06-05 12:50:00 UTC

Size: 1.18 KB

patch

obsolete

>From 92ebd16cee2a7a306abae7fd3cba3f1366471f14 Mon Sep 17 00:00:00 2001
>From: Beniamino Galvani <bgalvani@redhat.com>
>Date: Tue, 5 Jun 2018 14:38:58 +0200
>Subject: [PATCH] cli: fix array out-of-bounds access on command timeout
>
>Fixes: 4b3297271e6f7502631719148d5880489ec56eff
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1573839
>---
> clients/cli/connections.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/clients/cli/connections.c b/clients/cli/connections.c
>index f8caa10df..9b66916fb 100644
>--- a/clients/cli/connections.c
>+++ b/clients/cli/connections.c
>@@ -2834,17 +2834,17 @@ connection_cb_info_finish (ConnectionCbInfo *info, gpointer obj)
> {
> 	if (obj) {
> 		obj = connection_cb_info_obj_list_steal (info, obj);
> 		if (obj)
> 			connection_cb_info_obj_list_destroy (info, obj);
> 	} else {
> 		while (info->obj_list->len > 0) {
> 			obj = info->obj_list->pdata[info->obj_list->len - 1];
>-			g_ptr_array_remove_index (info->obj_list, info->obj_list->len);
>+			g_ptr_array_remove_index (info->obj_list, info->obj_list->len - 1);
> 			connection_cb_info_obj_list_destroy (info, obj);
> 		}
> 	}
> 
> 	if (info->obj_list->len > 0)
> 		return;
> 
> 	nm_clear_g_source (&info->timeout_id);
>-- 
>2.17.0
>

Actions: View | Diff

Attachments on bug 1573839: 1447855