Attachment 144868 Details for Bug 220966 – Patch to David Miller's net-2.6 git tree

[patch] Patch to David Miller's net-2.6 git tree

netlabel-softirq_lock_safety (text/plain), 1.04 KB, created by Paul Moore on 2007-01-04 23:54:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Paul Moore

Created: 2007-01-04 23:54:08 UTC

Size: 1.04 KB

patch

obsolete

>Subject: NetLabel: correct locking in selinux_netlbl_socket_setsid()
>
>From: Paul Moore <paul.moore@hp.com>
>
>The spinlock protecting the update of the "sksec->nlbl_state" variable is not
>currently softirq safe which can lead to problems.  This patch fixes this by
>changing the spin_{un}lock() functions into spin_{un}lock_bh() functions.
>
>Signed-off-by: Paul Moore <paul.moore@hp.com>
>---
> security/selinux/ss/services.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>Index: net-2.6.20_bugfix_3/security/selinux/ss/services.c
>===================================================================
>--- net-2.6.20_bugfix_3.orig/security/selinux/ss/services.c
>+++ net-2.6.20_bugfix_3/security/selinux/ss/services.c
>@@ -2492,9 +2492,9 @@ static int selinux_netlbl_socket_setsid(
> 
> 	rc = netlbl_socket_setattr(sock, &secattr);
> 	if (rc == 0) {
>-		spin_lock(&sksec->nlbl_lock);
>+		spin_lock_bh(&sksec->nlbl_lock);
> 		sksec->nlbl_state = NLBL_LABELED;
>-		spin_unlock(&sksec->nlbl_lock);
>+		spin_unlock_bh(&sksec->nlbl_lock);
> 	}
> 
> netlbl_socket_setsid_return:

Actions: View | Diff

Attachments on bug 220966: 144868