Attachment 144931 Details for Bug 221641 – This patch is based on -158.el5 and, can fix this problem.

[patch] This patch is based on -158.el5 and, can fix this problem.

kexec-tools-1.101-check-available-size-02.patch (text/plain), 4.58 KB, created by Akira Imamura on 2007-01-05 21:04:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Akira Imamura

Created: 2007-01-05 21:04:19 UTC

Size: 4.58 KB

patch

obsolete

>--- mkdumprd.org	2007-01-05 15:23:11.000000000 -0500
>+++ /sbin/mkdumprd	2007-01-05 16:01:09.000000000 -0500
>@@ -1422,6 +1422,19 @@ kdump_chk()
>     echo "$KDUMP_CONFIG_FILE: $2"
>     exit 1
> }
>+
>+check_availability()
>+{
>+    local available_size=$1
>+    local memtotal=$2
>+    local location=$3
>+
>+    if [ $available_size -lt $memtotal ]; then
>+        echo "Warning: There is not space enough to save a vmcore."
>+        echo "         The size of $location should be much greater than $memtotal bytes."
>+    fi
>+}
>+
> if [ -n "$KDUMP_CONFIG_FILE" ]; then
>     memtotal=`cat /proc/meminfo | grep MemTotal | awk '{print $2}'`
>     
>@@ -1462,7 +1475,9 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
>                     #test raw partition
>                     kdump_chk "dd if=$location count=1 of=/dev/null > /dev/null 2>&1" \
>                                "Bad raw partition $location"
>-                    #TODO check for available size is greater than $memtotal
>+
>+                    available_size=$(fdisk -s $location)
>+                    check_availability $available_size $memtotal $location
> 
>                     #setup raw case
>                     emit "echo Saving to partition $location"
>@@ -1529,25 +1544,27 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
>                                    "Bad NFS mount $location"
>                         mkdir -p $tmnt/$SAVE_PATH
>                         tdir=`mktemp -dqp $tmnt/$SAVE_PATH`
>+                        if [ $? != "0" ]; then 
>+                            echo "Cannot create directory in $location: $SAVE_PATH"
>+                            exit 1 
>+                        fi
> 
>-                        rc=$? && rm -rf $tdir 
>+                        available_size=$(df $tdir | tail -1 | tr -s ' ' ':' | cut -d: -f4)
>+                        check_availability $available_size $memtotal $location
>+
>+                        rm -rf $tdir 
>                         umount $tmnt
>                         if [ $? != 0 ]; then
>                             echo "Cannot unmount the temporary directory"
>                             exit 1
>                         fi
>                         rm -rf $tmnt
>-                        if [ $rc != "0" ]; then 
>-                            echo "Cannot create directory in $location: $SAVE_PATH"
>-                            exit 1 
>-                        fi
> 
>                         if [ -z "$CORE_COLLECTOR" ]; then
>                             CORE_COLLECTOR="cp"
>                         fi
> 
>-                        #TODO check for available size is greater than $memtotal
>-    
>+
>                         #setup nfs case
>                         mkdir -p $MNTIMAGE/mnt
>                         emit "mount -t nfs -o nolock $rlocation /mnt"
>@@ -1570,10 +1587,15 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
>                         kdump_chk "ssh -q $s_opts $rlocation mkdir -p $SAVE_PATH </dev/null" \
>                                 "Could not create $location:$SAVE_PATH, you probably need to run \"service kdump propagate\""
>                         tdir=`ssh -q $s_opts $rlocation mktemp -dqp $SAVE_PATH </dev/null`
>+
>                         if [ $? != "0" ]; then
>                             echo "$KDUMP_CONFIG_FILE: Could not create temp directory in $location:$SAVE_PATH"
>                             exit 1
>                         fi
>+
>+                        available_size=$(ssh -q $s_opts $rlocation df $SAVE_PATH | tail -1 | tr -s ' ' ':' | cut -d: -f4)
>+                        check_availability $available_size $memtotal $location:$SAVE_PATH
>+
>                         #We do this to remove the temp directory from above
>                         ssh -q $s_opts $rlocation rmdir $tdir
> 
>@@ -1609,13 +1631,16 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
>                     kdump_chk "mount -t $type $location /mnt" "Bad mount point $location"
>                     mkdir -p /mnt/$SAVE_PATH
>                     tdir=`mktemp -dqp /mnt/$SAVE_PATH`
>-                    rc=$? && rm -rf $tdir && umount /mnt
>-                    if [ $rc != "0" ]; then 
>+                    if [ $? != "0" ]; then 
>                         echo "Cannot create directory in $location: $SAVE_PATH"
>                         exit 1
>                     fi
>-                    #TODO check for available size is greater than $memtotal
>-    
>+                    available_size=$(df $tdir | tail -1 | tr -s ' ' ':' | cut -d: -f4)
>+                    check_availability $available_size $memtotal $location
>+
>+                    rm -rf $tdir
>+                    umount /mnt
>+ 
>                     #setup filesystem case
>                     mkdir -p $MNTIMAGE/mnt
> 		    touch $MNTIMAGE/etc/mtab

Actions: View | Diff

Attachments on bug 221641: 144924 | 144931