Attachment 1451464 Details for Bug 1575601 – review checklist for beaker-libraries

review checklist for beaker-libraries

review.txt (text/plain), 11.92 KB, created by Tim Flink on 2018-06-14 16:45:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tim Flink

Created: 2018-06-14 16:45:53 UTC

Size: 11.92 KB

patch

obsolete

>Package Review
>==============
>
>Legend:
>[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>[ ] = Manual review needed
>
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[-]: If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %license.
>[!]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses
>     found: "GPL (v2 or later)", "Unknown or generated". 86 files have
>     unknown license. Detailed output of licensecheck in
>     /home/tflink/code/packages/beakerlib-libraries/review-beakerlib-
>     libraries/licensecheck.txt
>[x]: Package contains no bundled libraries without FPC exception.
>[x]: Changelog in prescribed format.
>[x]: Sources contain only permissible code or content.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Requires correct, justified where necessary.
>[x]: Spec file is legible and written in American English.
>[-]: Package contains systemd file(s) if in need.
>[x]: Package is not known to require an ExcludeArch tag.
>[!]: Package complies to the Packaging Guidelines
>[x]: Package successfully compiles and builds into binary rpms on at least
>     one supported primary architecture.
>[x]: Package installs properly.
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Package requires other packages for directories it uses.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[x]: Dist tag is present.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>     work.
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package does not use a name that already exists.
>[x]: Package is not relocatable.
>[x]: Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: File names are valid UTF-8.
>[-]: Large documentation must go in a -doc subpackage. Large could be size
>     (~1MB) or number of files.
>     Note: Documentation size is 0 bytes in 0 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[!]: Sources can be downloaded from URI in Source: tag
>     Note: Could not download Source0: https://releases.pagure.org
>     /beakerlib-libraries/beakerlib-libraries-0.2.tar.gz
>     See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
>[!]: If the source package does not include license text(s) as a separate
>     file from upstream, the packager SHOULD query upstream to include it.
>[!]: Final provides and requires are sane (see attachments).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[!]: SourceX tarball generation or download is documented.
>     Note: Package contains tarball without URL, check comments
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed
>     files.
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
>[x]: SourceX is a working URL.
>[x]: Spec use %global instead of %define unless justified.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>
>
>Rpmlint
>-------
>Checking: beakerlib-libraries-0.2-1.fc29.noarch.rpm
>          beakerlib-libraries-0.2-1.fc29.src.rpm
>beakerlib-libraries.noarch: E: explicit-lib-dependency beakerlib
>beakerlib-libraries.noarch: W: no-documentation
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/authconfig/basic/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/bind/bind-setup/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/Cleanup/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/Log/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/RpmSnapshot/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/dpcommon/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/dump/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/epel/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/opts/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/sundry/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/kernel/base/lib-compat.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/kernel/base/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: W: devel-file-in-non-devel-package /usr/share/beakerlib-libraries/kernel/base/src/expendfdrun/expendfdrun.c
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/nginx/nginx/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/openssl/certgen/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/openssl/certgen/runtest.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/perl/subpackage/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/php/utils/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/samba/samba-bits/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/sos/utils/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/squid/squid/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/tuned/basic/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/yum/common-functions/lib.sh 644 /bin/bash 
>beakerlib-libraries.src: W: invalid-url Source0: https://releases.pagure.org/beakerlib-libraries/beakerlib-libraries-0.2.tar.gz HTTP Error 404: Not Found
>2 packages and 0 specfiles checked; 23 errors, 3 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
>beakerlib-libraries.noarch: E: explicit-lib-dependency beakerlib
>beakerlib-libraries.noarch: W: invalid-url URL: https://pagure.io/beakerlib-libraries/ <urlopen error [Errno -2] Name or service not known>
>beakerlib-libraries.noarch: W: no-documentation
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/authconfig/basic/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/bind/bind-setup/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/Cleanup/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/Log/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/RpmSnapshot/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/dpcommon/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/dump/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/epel/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/opts/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/distribution/sundry/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/kernel/base/lib-compat.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/kernel/base/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: W: devel-file-in-non-devel-package /usr/share/beakerlib-libraries/kernel/base/src/expendfdrun/expendfdrun.c
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/nginx/nginx/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/openssl/certgen/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/openssl/certgen/runtest.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/perl/subpackage/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/php/utils/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/samba/samba-bits/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/sos/utils/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/squid/squid/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/tuned/basic/lib.sh 644 /bin/bash 
>beakerlib-libraries.noarch: E: non-executable-script /usr/share/beakerlib-libraries/yum/common-functions/lib.sh 644 /bin/bash 
>1 packages and 0 specfiles checked; 23 errors, 3 warnings.
>
>
>
>Requires
>--------
>beakerlib-libraries (rpmlib, GLIBC filtered):
>    /bin/bash
>    beakerlib
>
>
>
>Provides
>--------
>beakerlib-libraries:
>    beakerlib-libraries
>
>
>
>Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02
>Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -n beakerlib-libraries
>Buildroot used: fedora-rawhide-x86_64
>Active plugins: Generic, Shell-api
>Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP
>Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Actions: View

Attachments on bug 1575601: 1451464