Attachment 1451506 Details for Bug 1591431 – functions: disable/enable_ksm(): silence no harmful errors

[patch] functions: disable/enable_ksm(): silence no harmful errors

0001-functions-disable-enable_ksm-silence-no-harmful-erro.patch (text/plain), 1.56 KB, created by Luiz Capitulino on 2018-06-14 17:41:26 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Luiz Capitulino

Created: 2018-06-14 17:41:26 UTC

Size: 1.56 KB

patch

obsolete

>From 938a6be3cb071df16db102784137fb4ea7c0cc78 Mon Sep 17 00:00:00 2001
>From: Luiz Capitulino <lcapitulino@redhat.com>
>Date: Thu, 14 Jun 2018 13:25:06 -0400
>Subject: [PATCH] functions: disable/enable_ksm(): silence no harmful errors
>
>systemctl is-enable, is-active and preset print errors if the
>service in question is not installed. This causes disable_ksm()
>and enable_ksm() to print lots of errors. Since the errors are
>not harmful (the function will do the right thing on failure),
>just ignore them.
>
>While there, pass -q to systemctl instead of the command name
>for consistency.
>
>Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
>---
> profiles/functions | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/profiles/functions b/profiles/functions
>index 2df8168..25bfe6b 100644
>--- a/profiles/functions
>+++ b/profiles/functions
>@@ -535,11 +535,11 @@ KSM_RUN_PATH=/sys/kernel/mm/ksm/run
> disable_ksm()
> {
> 	for s in $KSM_SERVICES; do
>-		if systemctl is-enabled -q $s; then
>+		if systemctl -q is-enabled $s 2> /dev/null; then
> 			systemctl -q disable $s
> 		fi
> 
>-		if systemctl is-active -q $s; then
>+		if systemctl -q is-active $s 2> /dev/null; then
> 			systemctl -q stop $s
> 		fi
> 	done
>@@ -553,11 +553,11 @@ disable_ksm()
> enable_ksm()
> {
> 	for s in $KSM_SERVICES; do
>-		systemctl -q preset $s
>+		systemctl -q preset $s 2> /dev/null
> 
> 		# Only start the service if it's enabled by defaut
>-		if systemctl is-enabled -q $s; then
>-			systemctl start $s
>+		if systemctl -q is-enabled $s 2> /dev/null; then
>+			systemctl -q start $s
> 		fi
> 	done
> }
>-- 
>2.14.4
>

Actions: View | Diff

Attachments on bug 1591431: 1451506