Attachment 1452067 Details for Bug 1589264 – If new MTU is not greater than mbuf size don't update HW

[patch] If new MTU is not greater than mbuf size don't update HW

0001-net-bnxt-fix-set-MTU.patch (text/plain), 1.39 KB, created by Ajit Khaparde on 2018-06-15 20:58:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ajit Khaparde

Created: 2018-06-15 20:58:23 UTC

Size: 1.39 KB

patch

obsolete

>From 7e3b66c50d2c5304f618f7cd267af0dec9be9553 Mon Sep 17 00:00:00 2001
>From: Ajit Khaparde <ajit.khaparde@broadcom.com>
>Date: Fri, 15 Jun 2018 13:57:06 -0700
>Subject: [PATCH] net/bnxt: fix set MTU
>
>There is no need to update hardware configuration if new MTU is
>not greater than the max data the mbuf can accommodate.
>Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>---
> drivers/net/bnxt/bnxt_ethdev.c | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
>index 52c511ee0..2021e1bb7 100644
>--- a/drivers/net/bnxt/bnxt_ethdev.c
>+++ b/drivers/net/bnxt/bnxt_ethdev.c
>@@ -1541,6 +1541,7 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
> 
> 	for (i = 0; i < bp->nr_vnics; i++) {
> 		struct bnxt_vnic_info *vnic = &bp->vnic_info[i];
>+		uint16_t size = 0;
> 
> 		vnic->mru = bp->eth_dev->data->mtu + ETHER_HDR_LEN +
> 					ETHER_CRC_LEN + VLAN_TAG_SIZE * 2;
>@@ -1548,9 +1549,14 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu)
> 		if (rc)
> 			break;
> 
>-		rc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
>-		if (rc)
>-			return rc;
>+		size = rte_pktmbuf_data_room_size(bp->rx_queues[0]->mb_pool);
>+		size -= RTE_PKTMBUF_HEADROOM;
>+
>+		if (size < new_mtu) {
>+			rc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic);
>+			if (rc)
>+				return rc;
>+		}
> 	}
> 
> 	return rc;
>-- 
>2.15.1 (Apple Git-101)
>

Actions: View | Diff

Attachments on bug 1589264: 1452067