Attachment 1454626 Details for Bug 1595211 – [PATCH] Pass "audacious" to gtk_init as argv[0] so that WM_CLASS gets set correctly

[patch] [PATCH] Pass "audacious" to gtk_init as argv[0] so that WM_CLASS gets set correctly

0001-Pass-audacious-to-gtk_init-as-argv-0-so-that-WM_CLAS.patch (text/plain), 1.32 KB, created by Hans de Goede on 2018-06-26 11:28:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Hans de Goede

Created: 2018-06-26 11:28:55 UTC

Size: 1.32 KB

patch

obsolete

>From f9b71870ced3466b62c8fdbe6adaf299db9ab63f Mon Sep 17 00:00:00 2001
>From: Hans de Goede <hdegoede@redhat.com>
>Date: Tue, 26 Jun 2018 13:09:16 +0200
>Subject: [PATCH] Pass "audacious" to gtk_init as argv[0] so that WM_CLASS gets
> set correctly
>
>Before this commit the WM_CLASS of gtk2 builds of audacious-3.9
>would be set to "<unknown>", "<unknown>".
>
>This commit passes "audacious" to gtk_init as argv[0], which changes
>WM_CLASS to "audacious", "Audacious".
>
>This fixes the Window title (in alt-tab) being <unknown> and a non svg icon
>being used under GNOME 3.28.
>
>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>---
> src/libaudgui/init.cc | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>diff --git a/src/libaudgui/init.cc b/src/libaudgui/init.cc
>index aa5b93cc5..c928bdb98 100644
>--- a/src/libaudgui/init.cc
>+++ b/src/libaudgui/init.cc
>@@ -140,12 +140,17 @@ static void playlist_position_cb (void * list, void *)
> 
> EXPORT void audgui_init ()
> {
>+    /* Dummy args to get gtk to set WM_CLASS */
>+    int argc = 1;
>+    char *_argv[] = { "audacious", NULL };
>+    char **argv = _argv;
>+
>     assert (aud_get_mainloop_type () == MainloopType::GLib);
> 
>     if (init_count ++)
>         return;
> 
>-    gtk_init (nullptr, nullptr);
>+    gtk_init (&argc, &argv);
> 
>     aud_config_set_defaults ("audgui", audgui_defaults);
> 
>-- 
>2.17.1
>

Actions: View | Diff

Attachments on bug 1595211: 1454626 | 1454962 | 1454964