Attachment 1455126 Details for Bug 1595389 – POC untested v1 patch for a tortoise and hare loop detection algo for the 'list' command

POC untested v1 patch for a tortoise and hare loop detection algo for the 'list' command

0001-Add-T-option-to-list-command-to-implement-storage-fr.patch (text/plain), 4.29 KB, created by Dave Wysochanski on 2018-06-27 20:25:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Wysochanski

Created: 2018-06-27 20:25:13 UTC

Size: 4.29 KB

patch

obsolete

>From 30aff140ba3473b5f7051efeecd8cc5a8b91b6c7 Mon Sep 17 00:00:00 2001
>From: Dave Wysochanski <dwysocha@redhat.com>
>Date: Wed, 27 Jun 2018 16:21:14 -0400
>Subject: [PATCH] Add 'T' option to 'list' command to implement storage free
> loop detection
>
>The 'T' option of the 'list' command implements a version of the tortoise
>and hare algorithm for loop detection.  The speed of the hare is set at
>2 and if it ever passes the tortoise a loop is detected.  The tortoise
>is the normal loop iteration.
>
>All other functions in the 'do_list()' function should remain in tact.
>This function is only implemented currently on the 'list' function by
>adding a '-T' on the crash list command.
>
>Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
>---
> Makefile | 14 +++++++-------
> defs.h   |  3 +++
> tools.c  | 26 ++++++++++++++++++++++++--
> 3 files changed, 34 insertions(+), 9 deletions(-)
>
>diff --git a/Makefile b/Makefile
>index f78da15..635cea1 100644
>--- a/Makefile
>+++ b/Makefile
>@@ -23,7 +23,7 @@ PROGRAM=crash
> # Supported targets: X86 ALPHA PPC IA64 PPC64 SPARC64
> # TARGET and GDB_CONF_FLAGS will be configured automatically by configure
> #
>-TARGET=
>+TARGET=X86_64
> GDB_CONF_FLAGS=
> 
> ARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ -e s/arm.*/arm/ -e s/sa110/arm/)
>@@ -34,10 +34,10 @@ endif
> #
> # GDB, GDB_FILES, GDB_OFILES and GDB_PATCH_FILES will be configured automatically by configure 
> #
>-GDB=
>-GDB_FILES=
>-GDB_OFILES=
>-GDB_PATCH_FILES=
>+GDB=gdb-7.6
>+GDB_FILES=${GDB_7.6_FILES}
>+GDB_OFILES=${GDB_7.6_OFILES}
>+GDB_PATCH_FILES=gdb-7.6.patch gdb-7.6-ppc64le-support.patch gdb-7.6-proc_service.h.patch
> 
> #
> # Default installation directory
>@@ -183,7 +183,7 @@ GDB_7.6_OFILES=${GDB}/gdb/symtab.o
> # 
> # GDB_FLAGS is passed up from the gdb Makefile.
> #
>-GDB_FLAGS=
>+GDB_FLAGS=-DGDB_7_6
> 
> #
> # WARNING_OPTIONS and WARNING_ERROR are both applied on a per-file basis. 
>@@ -200,7 +200,7 @@ TARGET_CFLAGS=
> 
> CRASH_CFLAGS=-g -D${TARGET} ${TARGET_CFLAGS} ${GDB_FLAGS} ${CFLAGS}
> 
>-GPL_FILES=
>+GPL_FILES=COPYING3
> TAR_FILES=${SOURCE_FILES} Makefile ${GPL_FILES} README .rh_rpm_package crash.8 \
> 	${EXTENSION_SOURCE_FILES} ${MEMORY_DRIVER_FILES}
> CSCOPE_FILES=${SOURCE_FILES}
>diff --git a/defs.h b/defs.h
>index 931be07..7019002 100644
>--- a/defs.h
>+++ b/defs.h
>@@ -2490,6 +2490,9 @@ struct list_data {             /* generic structure used by do_list() to walk */
> #define CALLBACK_RETURN     (VERBOSE << 12)
> #define LIST_PARSE_MEMBER   (VERBOSE << 13)
> #define LIST_READ_MEMBER    (VERBOSE << 14)
>+#define LIST_TORTOISE_HARE  (VERBOSE << 15)
>+
>+#define HARE_SPEED 2
> 
> struct tree_data {
> 	ulong flags;
>diff --git a/tools.c b/tools.c
>index 1a83643..e0cb940 100644
>--- a/tools.c
>+++ b/tools.c
>@@ -3266,9 +3266,13 @@ cmd_list(void)
> 	BZERO(ld, sizeof(struct list_data));
> 	struct_list_offset = 0;
> 
>-	while ((c = getopt(argcnt, args, "Hhrs:S:e:o:xdl:")) != EOF) {
>+	while ((c = getopt(argcnt, args, "THhrs:S:e:o:xdl:")) != EOF) {
>                 switch(c)
> 		{
>+		case 'T':
>+			ld->flags |= LIST_TORTOISE_HARE;
>+			ld->flags &= LIST_ALLOCATE;
>+
> 		case 'H':
> 			ld->flags |= LIST_HEAD_FORMAT;
> 			ld->flags |= LIST_HEAD_POINTER;
>@@ -3655,6 +3659,7 @@ int
> do_list(struct list_data *ld)
> {
> 	ulong next, last, first, offset;
>+	ulong hare, hare_idx;
> 	ulong searchfor, readflag;
> 	int i, count, others, close_hq_on_return;
> 	unsigned int radix;
>@@ -3776,7 +3781,8 @@ do_list(struct list_data *ld)
> 			}
> 		}
> 
>-                if (next && !hq_enter(next - ld->list_head_offset)) {
>+                if (!(ld->flags & LIST_TORTOISE_HARE) &&
>+		    next && !hq_enter(next - ld->list_head_offset)) {
> 			if (ld->flags & 
> 			    (RETURN_ON_DUPLICATE|RETURN_ON_LIST_ERROR)) {
>                         	error(INFO, "\nduplicate list entry: %lx\n", 
>@@ -3808,6 +3814,22 @@ do_list(struct list_data *ld)
> 			return -1;
> 		}
> 
>+		if (ld->flags & LIST_TORTOISE_HARE) {
>+			hare = next;
>+			for (hare_idx = 0; hare_idx < HARE_SPEED; hare_idx++) {
>+				if (!readmem(hare + ld->member_offset, KVADDR, &hare,
>+					     sizeof(void *), "list entry", readflag)) {
>+					error(INFO, "\ninvalid list entry: %lx\n", hare);
>+					return -1;
>+				}
>+				if (hare == next) {
>+					error(INFO, "\nduplicate list entry: %lx\n",
>+					      next);
>+					return -1;
>+				}
>+			}
>+		}
>+
> 		if (next == 0) {
> 			if (ld->flags & LIST_HEAD_FORMAT) {
> 				error(INFO, "\ninvalid list entry: 0\n");
>-- 
>1.8.3.1
>

Actions: View

Attachments on bug 1595389: 1455126 | 1455134 | 1455139 | 1455200 | 1455222