Attachment 145712 Details for Bug 222883 – Upstream patch for Squid FTP triggered DoS #1857

[patch] Upstream patch for Squid FTP triggered DoS #1857

bug1857.patch (text/plain), 1.26 KB, created by Lubomir Kundrak on 2007-01-16 18:29:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lubomir Kundrak

Created: 2007-01-16 18:29:37 UTC

Size: 1.26 KB

patch

obsolete

>Index: src/ftp.c
>===================================================================
>RCS file: /cvsroot/squid/squid/src/ftp.c,v
>retrieving revision 1.340
>diff -u -p -r1.340 ftp.c
>--- src/ftp.c	18 Sep 2006 23:03:36 -0000	1.340
>+++ src/ftp.c	1 Jan 2007 21:35:03 -0000
>@@ -434,7 +434,7 @@ ftpListingFinish(FtpStateData * ftpState
> 	    ftpState->flags.dir_slash ? rfc1738_escape_part(ftpState->old_filepath) : ".");
>     } else if (ftpState->typecode == 'D') {
> 	const char *path = ftpState->flags.dir_slash ? ftpState->filepath : ".";
>-	storeAppendPrintf(e, "<A HREF=\"%s/\">[As extended directory]</A>\n", html_quote(path));
>+	storeAppendPrintf(e, "<A HREF=\"%s/\">[As extended directory]</A>\n", rfc1738_escape_part(path));
>     }
>     storeAppendPrintf(e, "<HR noshade size=\"1px\">\n");
>     storeAppendPrintf(e, "<ADDRESS>\n");
>@@ -682,8 +682,8 @@ ftpHtmlifyListEntry(const char *line, Ft
> 	snprintf(html, 8192, "%s\n", line);
> 	return html;
>     }
>-    if (ftpState->flags.dir_slash)
>-	snprintf(prefix, sizeof(prefix), "%s/", rfc1738_escape_part(ftpState->dirpath));
>+    if (ftpState->flags.dir_slash && ftpState->dirpath && ftpState->typecode != 'D' )
>+	snprintf(prefix, 2048, "%s/", rfc1738_escape_part(ftpState->dirpath));
>     else
> 	prefix[0] = '\0';
>     /* Handle builtin <dirup> */

Actions: View | Diff

Attachments on bug 222883: 145712