Attachment 147230 Details for Bug 223818 – linux-2.6.9-net-sctp-icmp-cleanup.patch

[patch] linux-2.6.9-net-sctp-icmp-cleanup.patch

linux-2.6.9-net-sctp-icmp-cleanup.patch (text/plain), 4.72 KB, created by Chris Williams on 2007-02-02 14:55:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Williams

Created: 2007-02-02 14:55:24 UTC

Size: 4.72 KB

patch

obsolete

>Index: linux-2.6.9/net/sctp/input.c
>===================================================================
>--- linux-2.6.9/net/sctp/input.c
>+++ linux-2.6.9/net/sctp/input.c	2007-02-01 10:48:38.000000000 +0100
>@@ -310,7 +310,6 @@
> /* Common lookup code for icmp/icmpv6 error handler. */
> struct sock *sctp_err_lookup(int family, struct sk_buff *skb,
> 			     struct sctphdr *sctphdr,
>-			     struct sctp_endpoint **epp,
> 			     struct sctp_association **app,
> 			     struct sctp_transport **tpp)
> {
>@@ -318,11 +317,10 @@
> 	union sctp_addr daddr;
> 	struct sctp_af *af;
> 	struct sock *sk = NULL;
>-	struct sctp_endpoint *ep = NULL;
> 	struct sctp_association *asoc = NULL;
> 	struct sctp_transport *transport = NULL;
> 
>-	*app = NULL; *epp = NULL; *tpp = NULL;
>+	*app = NULL; *tpp = NULL;
> 
> 	af = sctp_get_af_specific(family);
> 	if (unlikely(!af)) {
>@@ -337,25 +335,15 @@
> 	 * packet.
> 	 */
> 	asoc = __sctp_lookup_association(&saddr, &daddr, &transport);
>-	if (!asoc) {
>-		/* If there is no matching association, see if it matches any
>-		 * endpoint. This may happen for an ICMP error generated in
>-		 * response to an INIT_ACK.
>-		 */
>-		ep = __sctp_rcv_lookup_endpoint(&daddr);
>-		if (!ep) {
>-			return NULL;
>-		}
>-	}
>+	if (!asoc)
>+		return NULL;
> 
>-	if (asoc) {
>-		if (ntohl(sctphdr->vtag) != asoc->c.peer_vtag) {
>-			ICMP_INC_STATS_BH(ICMP_MIB_INERRORS);
>-			goto out;
>-		}
>-		sk = asoc->base.sk;
>-	} else
>-		sk = ep->base.sk;
>+	sk = asoc->base.sk;
>+
>+	if (ntohl(sctphdr->vtag) != asoc->c.peer_vtag) {
>+		ICMP_INC_STATS_BH(ICMP_MIB_INERRORS);
>+		goto out;
>+	}
> 
> 	sctp_bh_lock_sock(sk);
> 
>@@ -365,7 +353,6 @@
> 	if (sock_owned_by_user(sk))
> 		NET_INC_STATS_BH(LINUX_MIB_LOCKDROPPEDICMPS);
> 
>-	*epp = ep;
> 	*app = asoc;
> 	*tpp = transport;
> 	return sk;
>@@ -374,21 +361,16 @@
> 	sock_put(sk);
> 	if (asoc)
> 		sctp_association_put(asoc);
>-	if (ep)
>-		sctp_endpoint_put(ep);
> 	return NULL;
> }
> 
> /* Common cleanup code for icmp/icmpv6 error handler. */
>-void sctp_err_finish(struct sock *sk, struct sctp_endpoint *ep,
>-		     struct sctp_association *asoc)
>+void sctp_err_finish(struct sock *sk, struct sctp_association *asoc)
> {
> 	sctp_bh_unlock_sock(sk);
> 	sock_put(sk);
> 	if (asoc)
> 		sctp_association_put(asoc);
>-	if (ep)
>-		sctp_endpoint_put(ep);
> }
> 
> /*
>@@ -413,7 +395,6 @@
> 	int type = skb->h.icmph->type;
> 	int code = skb->h.icmph->code;
> 	struct sock *sk;
>-	struct sctp_endpoint *ep;
> 	struct sctp_association *asoc;
> 	struct sctp_transport *transport;
> 	struct inet_opt *inet;
>@@ -430,7 +411,7 @@
> 	savesctp  = skb->h.raw;
> 	skb->nh.iph = iph;
> 	skb->h.raw = (char *)sh;
>-	sk = sctp_err_lookup(AF_INET, skb, sh, &ep, &asoc, &transport);
>+	sk = sctp_err_lookup(AF_INET, skb, sh, &asoc, &transport);
> 	/* Put back, the original pointers. */
> 	skb->nh.raw = saveip;
> 	skb->h.raw = savesctp;
>@@ -480,7 +461,7 @@
> 	}
> 
> out_unlock:
>-	sctp_err_finish(sk, ep, asoc);
>+	sctp_err_finish(sk, asoc);
> }
> 
> /*
>Index: linux-2.6.9/net/sctp/ipv6.c
>===================================================================
>--- linux-2.6.9/net/sctp/ipv6.c
>+++ linux-2.6.9/net/sctp/ipv6.c	2007-02-01 10:44:01.000000000 +0100
>@@ -88,7 +88,6 @@
> 	struct ipv6hdr *iph = (struct ipv6hdr *)skb->data;
> 	struct sctphdr *sh = (struct sctphdr *)(skb->data + offset);
> 	struct sock *sk;
>-	struct sctp_endpoint *ep;
> 	struct sctp_association *asoc;
> 	struct sctp_transport *transport;
> 	struct ipv6_pinfo *np;
>@@ -102,7 +101,7 @@
> 	savesctp  = skb->h.raw;
> 	skb->nh.ipv6h = iph;
> 	skb->h.raw = (char *)sh;
>-	sk = sctp_err_lookup(AF_INET6, skb, sh, &ep, &asoc, &transport);
>+	sk = sctp_err_lookup(AF_INET6, skb, sh, &asoc, &transport);
> 	/* Put back, the original pointers. */
> 	skb->nh.raw = saveip;
> 	skb->h.raw = savesctp;
>@@ -133,7 +132,7 @@
> 	}
> 
> out_unlock:
>-	sctp_err_finish(sk, ep, asoc);
>+	sctp_err_finish(sk, asoc);
> out:
> 	if (likely(idev != NULL))
> 		in6_dev_put(idev);
>Index: linux-2.6.9/include/net/sctp/sctp.h
>===================================================================
>--- linux-2.6.9/include/net/sctp/sctp.h
>+++ linux-2.6.9/include/net/sctp/sctp.h	2007-02-01 10:26:49.000000000 +0100
>@@ -174,11 +174,9 @@
> 	const union sctp_addr *,
> 	struct sctp_transport **);
> struct sock *sctp_err_lookup(int family, struct sk_buff *,
>-			     struct sctphdr *, struct sctp_endpoint **,
>-			     struct sctp_association **,
>+			     struct sctphdr *, struct sctp_association **,
> 			     struct sctp_transport **);
>-void sctp_err_finish(struct sock *, struct sctp_endpoint *,
>-			    struct sctp_association *);
>+void sctp_err_finish(struct sock *, struct sctp_association *);
> void sctp_icmp_frag_needed(struct sock *, struct sctp_association *,
> 			   struct sctp_transport *t, __u32 pmtu);
>

Actions: View | Diff

Attachments on bug 223818: 147230 | 147252