Attachment 147253 Details for Bug 227167 – Patch to implement finding addrname of functions with st_size=0.

[patch] Patch to implement finding addrname of functions with st_size=0.

dwfl_module_addrname.patch (text/plain), 1.32 KB, created by Nurdin Premji on 2007-02-02 21:30:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nurdin Premji

Created: 2007-02-02 21:30:12 UTC

Size: 1.32 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P frysk
>Index: frysk-imports/elfutils/libdwfl/dwfl_module_addrname.c
>===================================================================
>RCS file: /cvs/frysk/frysk-imports/elfutils/libdwfl/dwfl_module_addrname.c,v
>retrieving revision 1.1
>diff -u -r1.1 dwfl_module_addrname.c
>--- frysk-imports/elfutils/libdwfl/dwfl_module_addrname.c	7 Aug 2006 22:11:09 -0000	1.1
>+++ frysk-imports/elfutils/libdwfl/dwfl_module_addrname.c	2 Feb 2007 21:23:59 -0000
>@@ -56,6 +56,9 @@
>   if (syments < 0)
>     return NULL;
> 
>+	GElf_Addr prev_value = 0;
>+	const char *prev_name = NULL;
>+	
>   /* Look through the symbol table for a matching symbol.  */
>   for (int i = 1; i < syments; ++i)
>     {
>@@ -64,7 +67,23 @@
>       if (name != NULL
> 	  && sym.st_value <= addr && addr < sym.st_value + sym.st_size)
> 	return name;
>+		
>+	if (prev_value == 0) 
>+		prev_value = sym.st_value;
>+	
>+	//Playing blackjack find the closest symbol to the given address without going over.
>+	if (sym.st_value > prev_value && sym.st_value <= addr)
>+	{
>+		prev_value = sym.st_value;
>+		
>+	//If this symbol doesn't have a size, it is a good candidate for the address.
>+	//Otherwise it isn't. (It should have been caught above).
>+		if (sym.st_size == 0)
>+			prev_name = name;
>+		else 
>+			prev_name = NULL;
>+	}		
>     }
> 
>-  return NULL;
>+  return prev_name;
> }

Actions: View | Diff

Attachments on bug 227167: 147253 | 147254