Attachment 1475110 Details for Bug 1485755 – Proposed fix which adds IPv4-compatible IPv6 address support to netsnmp_udp6_parse_security()

[patch] Proposed fix which adds IPv4-compatible IPv6 address support to netsnmp_udp6_parse_security()

0001-Check-in-changes-to-add-IPv4-compatible-IPv6-address.patch (text/plain), 3.47 KB, created by Richard D Alloway on 2018-08-10 15:27:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Richard D Alloway

Created: 2018-08-10 15:27:10 UTC

Size: 3.47 KB

patch

obsolete

>From 5da20d65a8c6c91d6bec8462235d249846332b68 Mon Sep 17 00:00:00 2001
>From: Rich Alloway <richard.alloway@roguewave.com>
>Date: Wed, 11 Jul 2018 17:08:29 -0400
>Subject: [PATCH] Check in changes to add IPv4-compatible IPv6 address support
> to netsnmp_udp6_parse_security() (resolves BZ#1485755)
>
>---
> .../SOURCES/rw001-IPv4compatibleIPv6addr.patch     | 22 ++++++++++++++++++++++
> src/rpmbuild/SPECS/net-snmp.spec                   |  7 ++++++-
> 2 files changed, 28 insertions(+), 1 deletion(-)
> create mode 100644 src/rpmbuild/SOURCES/rw001-IPv4compatibleIPv6addr.patch
>
>diff --git a/src/rpmbuild/SOURCES/rw001-IPv4compatibleIPv6addr.patch b/src/rpmbuild/SOURCES/rw001-IPv4compatibleIPv6addr.patch
>new file mode 100644
>index 0000000..573ce11
>--- /dev/null
>+++ b/src/rpmbuild/SOURCES/rw001-IPv4compatibleIPv6addr.patch
>@@ -0,0 +1,22 @@
>+diff -Npru BUILD/net-snmp-5.7.2.orig/snmplib/transports/snmpUDPIPv6Domain.c BUILD/net-snmp-5.7.2/snmplib/transports/snmpUDPIPv6Domain.c
>+--- a/snmplib/transports/snmpUDPIPv6Domain.c	2018-06-14 14:37:02.998000000 -0400
>++++ b/snmplib/transports/snmpUDPIPv6Domain.c	2018-06-27 11:24:38.238000000 -0400
>+@@ -582,12 +582,18 @@ netsnmp_udp6_parse_security(const char *
>+             struct sockaddr_in6 pton_addr;
>+             struct addrinfo hints, *res = NULL;
>+             memset(&hints, '\0', sizeof(hints));
>++            char sourceTmp[302]; /* source(300)+2*':' */
>++
>++            sprintf( &sourceTmp, "::%s", source );  /* Source may be an IPv4 address, so we'd need to reformat as an IPv4-compatible IPv6 address */
>+ 
>+             /* First check if default, otherwise try to parse as a numeric
>+              * address, if that also fails try to lookup the address */
>+             if (isdefault) {
>+                 memset(&pton_addr.sin6_addr.s6_addr, '\0',
>+                        sizeof(struct in6_addr));
>++            } else if (inet_pton(AF_INET6, sourceTmp, &pton_addr.sin6_addr) == 1) {
>++                /* Yup, it was an IPv4 address (mapped to IPv6) */
>++		;
>+             } else if (inet_pton(AF_INET6, source, &pton_addr.sin6_addr) != 1) {
>+                 /* Nope, wasn't a numeric address. Must be a hostname. */
>+ #if HAVE_GETADDRINFO
>diff --git a/src/rpmbuild/SPECS/net-snmp.spec b/src/rpmbuild/SPECS/net-snmp.spec
>index a59db4f..022f99f 100644
>--- a/src/rpmbuild/SPECS/net-snmp.spec
>+++ b/src/rpmbuild/SPECS/net-snmp.spec
>@@ -11,7 +11,7 @@
> Summary: A collection of SNMP protocol tools and libraries
> Name: net-snmp
> Version: 5.7.2
>-Release: 33%{?dist}.2
>+Release: 33_rw001%{?dist}.2
> Epoch: 1
> 
> License: BSD
>@@ -103,6 +103,7 @@ Patch67: net-snmp-5.7.2-iterator-fix.patch
> Patch68: net-snmp-5.7.2-autofs.patch
> Patch69: net-snmp-5.7.2-leak-backport.patch
> Patch70: net-snmp-5.7.2-acfs.patch
>+Patch71: rw001-IPv4compatibleIPv6addr.patch
> 
> Requires(post): chkconfig
> Requires(preun): chkconfig
>@@ -326,6 +327,7 @@ The net-snmp-sysvinit package provides SysV init scripts for Net-SNMP daemons.
> %patch68 -p1 -b .autofspatch
> %patch69 -p1 -b .leak-backport
> %patch70 -p1 -b .acfs
>+%patch71 -p1 -b .rw001
> 
> %ifarch sparc64 s390 s390x
> # disable failing test - see https://bugzilla.redhat.com/show_bug.cgi?id=680697
>@@ -621,6 +623,9 @@ rm -rf ${RPM_BUILD_ROOT}
> %{_initrddir}/snmptrapd
> 
> %changelog
>+* Mon Jun 27 2018 Rich Alloway <richard.alloway@roguewave.com> - 1:5.7.2-33_rw001.2
>+- Add IPv4-compatible IPv6 address support to netsnmp_udp6_parse_security() (#1485755)
>+
> * Mon Apr 23 2018 Josef Ridky <jridky@redhat.com> - 1:5.7.2-33.2
> - Add ACFS support (#1570506)
> 
>-- 
>1.8.3.1
>

Actions: View | Diff

Attachments on bug 1485755: 1475110