Attachment 1477908 Details for Bug 1619386 – Backport of upstream patch

[patch] Backport of upstream patch

0001-Heap-overflow-patch.patch (text/plain), 1.70 KB, created by Marcel Plch on 2018-08-22 14:52:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel Plch

Created: 2018-08-22 14:52:47 UTC

Size: 1.70 KB

patch

obsolete

>From d1fa689356602d853c246a737b7cbf5ffa5a2aba Mon Sep 17 00:00:00 2001
>From: Marcel Plch <mplch@redhat.com>
>Date: Wed, 22 Aug 2018 16:47:25 +0200
>Subject: [PATCH] Heap overflow patch
>
>---
> fix-heap-overflow.patch  | 16 ++++++++++++++++
> python-subprocess32.spec |  4 ++++
> 2 files changed, 20 insertions(+)
> create mode 100644 fix-heap-overflow.patch
>
>diff --git a/fix-heap-overflow.patch b/fix-heap-overflow.patch
>new file mode 100644
>index 0000000..6434496
>--- /dev/null
>+++ b/fix-heap-overflow.patch
>@@ -0,0 +1,16 @@
>+diff -ru subprocess32-3.2.6/_posixsubprocess_helpers.c subprocess32-3.2.6_patched/_posixsubprocess_helpers.c
>+--- subprocess32-3.2.6/_posixsubprocess_helpers.c	2012-06-09 08:31:40.000000000 +0200
>++++ subprocess32-3.2.6_patched/_posixsubprocess_helpers.c	2018-08-22 16:38:07.485734481 +0200
>+@@ -110,6 +110,12 @@
>+     if (argc == -1)
>+         return NULL;
>+ 
>++    /* Avoid 32-bit overflows to malloc() from unreasonable values. */
>++    if (argc > 0x10000000) {
>++        PyErr_NoMemory();
>++        return NULL;
>++    }
>++
>+     array = malloc((argc + 1) * sizeof(char *));
>+     if (array == NULL) {
>+         PyErr_NoMemory();
>diff --git a/python-subprocess32.spec b/python-subprocess32.spec
>index 2347399..6978871 100644
>--- a/python-subprocess32.spec
>+++ b/python-subprocess32.spec
>@@ -18,6 +18,8 @@ Source0:        https://files.pythonhosted.org/packages/source/s/%{srcname}/%{sr
> BuildRequires:  python2-devel
> BuildRequires:  python-test
> 
>+Patch0:     fix-heap-overflow.patch
>+
> %global _description\
> Backport of the subprocess module from Python 3.2 for use on 2.x.\
> 
>@@ -33,6 +35,8 @@ Summary: %summary
> %prep
> %setup -q -n subprocess32-%{version}
> 
>+%patch0 -p1
>+
> 
> %build
> %py2_build
>-- 
>2.17.1
>

Actions: View | Diff

Attachments on bug 1619386: 1477908