Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 148063 Details for
Bug 228713
[RHEL4] [patch] cid-2 remove dead code in lib/ss/help.c
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Remove invariant (code != 0) check in lib/ss/help.c
e2fsprogs-1.35-drop_invariant_check.patch (text/plain), 682 bytes, created by
Bryn M. Reeves
on 2007-02-14 16:31:00 UTC
(
hide
)
Description:
Remove invariant (code != 0) check in lib/ss/help.c
Filename:
MIME Type:
Creator:
Bryn M. Reeves
Created:
2007-02-14 16:31:00 UTC
Size:
682 bytes
patch
obsolete
>Coverity ID: 2: Deadcode > >Looks like ss_current_request is a macro that will set code to 0. This test >will always be false. I will remove this error case. > >Index: e2fsprogs+chaos/lib/ss/help.c >=================================================================== >--- e2fsprogs+chaos.orig/lib/ss/help.c >+++ e2fsprogs+chaos/lib/ss/help.c >@@ -49,10 +49,6 @@ void ss_help (argc, argv, sci_idx, info_ > register ss_data *info; > > request_name = ss_current_request(sci_idx, &code); >- if (code != 0) { >- ss_perror(sci_idx, code, ""); >- return; /* no ss_abort_line, if invalid invocation */ >- } > if (argc == 1) { > ss_list_requests(argc, argv, sci_idx, info_ptr); > return;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=148063">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 228713
: 148063