Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 148065 Details for
Bug 228716
[RHEL4] [patch] cid-12 Avoid static buffer overruns in debugfs
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Patch correcting array usage in rdump_dirent
e2fsprogs-1.35-debugfs_dump_name.patch (text/plain), 914 bytes, created by
Bryn M. Reeves
on 2007-02-14 16:43:56 UTC
(
hide
)
Description:
Patch correcting array usage in rdump_dirent
Filename:
MIME Type:
Creator:
Bryn M. Reeves
Created:
2007-02-14 16:43:56 UTC
Size:
914 bytes
patch
obsolete
>Coverity ID: 12: Overrun Static > >Add an extra byte to EXT2_NAME_LEN in the static allocation for the >required trailing NULL. This allows filenames up to the maximum >length of EXT2_NAME_LEN withover an overrun. > >Index: e2fsprogs+chaos/debugfs/dump.c >=================================================================== >--- e2fsprogs+chaos.orig/debugfs/dump.c >+++ e2fsprogs+chaos/debugfs/dump.c >@@ -292,12 +292,12 @@ static int rdump_dirent(struct ext2_dir_ > int blocksize EXT2FS_ATTR((unused)), > char *buf EXT2FS_ATTR((unused)), void *private) > { >- char name[EXT2_NAME_LEN]; >+ char name[EXT2_NAME_LEN + 1]; > int thislen; > const char *dumproot = private; > struct ext2_inode inode; > >- thislen = ((dirent->name_len & 0xFF) < EXT2_NAME_LEN >+ thislen = ((dirent->name_len & 0xFF) <= EXT2_NAME_LEN > ? (dirent->name_len & 0xFF) : EXT2_NAME_LEN); > strncpy(name, dirent->name, thislen); > name[thislen] = 0;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=148065">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 228716
: 148065