Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 148068 Details for
Bug 228722
[RHEL4] [patch] cid-10 Add missing NULL check to e2fsck_get_dir_info()
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
e2fsck - check return value of e2fsck_get_dir_info()
e2fsprogs-1.35-check_directory_null.patch (text/plain), 814 bytes, created by
Bryn M. Reeves
on 2007-02-14 17:02:19 UTC
(
hide
)
Description:
e2fsck - check return value of e2fsck_get_dir_info()
Filename:
MIME Type:
Creator:
Bryn M. Reeves
Created:
2007-02-14 17:02:19 UTC
Size:
814 bytes
patch
obsolete
>Coverity ID: 10: Null Returns > >It is possible that e2fsck_get_dir_info() returns a NULL pointer. >We do not want to blow up when dereferencing p. It seems to be >more sane/safe to call fix_problem(ctx, PR_3_NO_DIRINFO, pctx) >if p is NULL at this point since we do not have any DIRINFO >for pctx->ino. > >Index: e2fsprogs+chaos/e2fsck/pass3.c >=================================================================== >--- e2fsprogs+chaos.orig/e2fsck/pass3.c >+++ e2fsprogs+chaos/e2fsck/pass3.c >@@ -306,6 +306,10 @@ static int check_directory(e2fsck_t ctx, > ext2fs_unmark_valid(fs); > else { > p = e2fsck_get_dir_info(ctx, pctx->ino); >+ if(!p) { >+ fix_problem(ctx, PR_3_NO_DIRINFO, pctx); >+ return 0; >+ } > p->parent = ctx->lost_and_found; > fix_dotdot(ctx, p, ctx->lost_and_found); > }
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=148068">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 228722
: 148068