Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 148070 Details for
Bug 228725
[RHEL4] [patch] cid-21 Fix memory leak in libss (ss_execute_line)
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Correct freeing of argv in ss_execute_line
e2fsprogs-1.35-free_argv.patch (text/plain), 820 bytes, created by
Bryn M. Reeves
on 2007-02-14 17:14:43 UTC
(
hide
)
Description:
Correct freeing of argv in ss_execute_line
Filename:
MIME Type:
Creator:
Bryn M. Reeves
Created:
2007-02-14 17:14:43 UTC
Size:
820 bytes
patch
obsolete
>Coverity ID: 21: Resource Leak > >Potentially need to free argv before early return since it was allocated >memory. Need to be careful since it may be possible for ss_parse() to have >freed the memory allocated to it if it detects an unbalanced set of quotes >passed to it. > >Index: e2fsprogs+chaos/lib/ss/execute_cmd.c >=================================================================== >--- e2fsprogs+chaos.orig/lib/ss/execute_cmd.c >+++ e2fsprogs+chaos/lib/ss/execute_cmd.c >@@ -220,8 +220,11 @@ int ss_execute_line (sci_idx, line_ptr) > > /* parse it */ > argv = ss_parse(sci_idx, line_ptr, &argc); >- if (argc == 0) >+ if (argc == 0) { >+ if (argv) >+ free(argv); > return 0; >+ } > > /* look it up in the request tables, execute if found */ > ret = really_execute_command (sci_idx, argc, &argv);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=148070">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 228725
: 148070