Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 148080 Details for
Bug 228737
[RHEL4] [patch] cid-32 Fix memory leak in fsck on error paths
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
fsck - free instance struct in execute() error paths
e2fsprogs-1.35-fsck_free_inst.patch (text/plain), 955 bytes, created by
Bryn M. Reeves
on 2007-02-14 18:40:54 UTC
(
hide
)
Description:
fsck - free instance struct in execute() error paths
Filename:
MIME Type:
Creator:
Bryn M. Reeves
Created:
2007-02-14 18:40:54 UTC
Size:
955 bytes
patch
obsolete
>Coverity ID: 32: Resource Leak > >The memory allocated by inst is not reclaimed. There also was a >call to exit that coverity did not catch the resource leak. This >might not really be a big issue since the memory will be freed when >fsck exits, but it should be done anyway imho. > >Index: e2fsprogs+chaos/misc/fsck.c >=================================================================== >--- e2fsprogs+chaos.orig/misc/fsck.c >+++ e2fsprogs+chaos/misc/fsck.c >@@ -470,6 +470,7 @@ static int execute(const char *type, con > s = find_fsck(prog); > if (s == NULL) { > fprintf(stderr, _("fsck: %s: not found\n"), prog); >+ free(inst); > return ENOENT; > } > >@@ -486,12 +487,14 @@ static int execute(const char *type, con > pid = -1; > else if ((pid = fork()) < 0) { > perror("fork"); >+ free(inst); > return errno; > } else if (pid == 0) { > if (!interactive) > close(0); > (void) execv(s, argv); > perror(argv[0]); >+ free(inst); > exit(EXIT_ERROR); > } >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=148080">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 228737
: 148080