Attachment 1485016 Details for Bug 1528207 – Patch for memleak in find_keytab_entry()

[patch] Patch for memleak in find_keytab_entry()

nfs-utils-1.2.3-rpc.gssd-fix-memory-leak-in-find_keytab_entry.patch (text/plain), 1.18 KB, created by Pierguido Lambri on 2018-09-20 06:22:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pierguido Lambri

Created: 2018-09-20 06:22:48 UTC

Size: 1.18 KB

patch

obsolete

>From 6e0ab52eac6860266dfcad8018f231d22f361889 Mon Sep 17 00:00:00 2001
>From: Pier <plambri@redhat.com>
>Date: Wed, 19 Sep 2018 22:03:58 +0100
>Subject: [PATCH] rpc.gssd: fix some memory leaks in find_keytab_entry().
>
>Signed-off-by: Pierguido Lambri <plambri@redhat.com>
>---
> utils/gssd/krb5_util.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c
>index 5f5d1c3..ff3724f 100644
>--- a/utils/gssd/krb5_util.c
>+++ b/utils/gssd/krb5_util.c
>@@ -930,6 +930,8 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, const char *hostname,
> 				goto out;
> 			}
> 			retval = code;
>+		if (k5err)
>+			free(k5err);
> 		}
> 		/*
> 		 * Nothing found with our hostname instance, now look for
>@@ -952,13 +954,18 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, const char *hostname,
> 			i++;
> 			realm = realmnames[i];
> 		}
>+	if (k5err)
>+		free(k5err);
> 	}
> out:
> 	if (default_realm)
> 		k5_free_default_realm(context, default_realm);
> 	if (realmnames)
> 		krb5_free_host_realm(context, realmnames);
>-	free(k5err);
>+    if (adhostoverride)
>+        free(adhostoverride);
>+    if (k5err)
>+        free(k5err);
> 	return retval;
> }
> 
>-- 
>2.17.1
>

Actions: View | Diff

Attachments on bug 1528207: 1485016