Attachment 148536 Details for Bug 229576 – email discussion

email discussion

template-scripts.html (text/html), 7.25 KB, created by Noriko Hosoi on 2007-02-21 21:19:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Noriko Hosoi

Created: 2007-02-21 21:19:33 UTC

Size: 7.25 KB

patch

obsolete

><html>
><head>
><title>Re: It&#39;s time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</title>
><link rel="important stylesheet" href="chrome://messenger/skin/messageBody.css">
></head>
><body>
><table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part1"><tr><td>Subject: Re: It's time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</td></tr><tr><td>From: Richard Megginson <rmeggins@redhat.com></td></tr><tr><td>Date: Wed, 21 Feb 2007 13:02:05 -0700</td></tr></table><table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part2"><tr><td>To: Noriko Hosoi <nhosoi@redhat.com></td></tr><tr><td>CC: ldap-devel-list <ldap-devel-list@redhat.com></td></tr></table> 
><div class="moz-text-flowed">Noriko Hosoi wrote:
> <blockquote type=cite>Rich sent out the original email some time back.&nbsp; Since we've (almost) 
>finished the migration to the new style build, isn't it a good time to 
>do it?&nbsp; I think to-be-eliminated files are in admin/src and 
>admin/src/scripts.&nbsp; Could there be anywhere else?
> </blockquote>I just did a quick search using this:
> find . -type f -print | while read file ; do if [ -f $file.in ] ; then 
>ls -al $file $file.in ; fi ; done
> 
> it matches your list below, so I guess there are no others.
> <blockquote type=cite>
> /share/dev4/ds/ds72/builds/20070221.1/earthquake_rhel4/BUILD/fedora-ds-1.1.0-20070221/ldap/admin/src 
>
> $ ls ds_newinst.pl* scripts/template-*
> ds_newinst.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateInstance7
> ds_newinst.pl.in&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateTo5*
> scripts/template-bak2db&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateTo6
> scripts/template-bak2db.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateTo7
> scripts/template-bak2db.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-monitor
> scripts/template-bak2db.pl.in&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-monitor.in*
> scripts/template-cl-dump.pl*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-accountstatus.pl
> scripts/template-cl-dump.pl.in*&nbsp;&nbsp;&nbsp; 
>scripts/template-ns-accountstatus.pl.in
> scripts/template-db2bak&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-activate.pl
> scripts/template-db2bak.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-activate.pl.in
> scripts/template-db2bak.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-inactivate.pl
> scripts/template-db2bak.pl.in&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-inactivate.pl.in
> scripts/template-db2index&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-newpwpolicy.pl*
> scripts/template-db2index.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-newpwpolicy.pl.in*
> scripts/template-db2index.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-repl-monitor-cgi.pl*
> scripts/template-db2index.pl.in&nbsp;&nbsp;&nbsp; 
>scripts/template-repl-monitor-cgi.pl.in*
> scripts/template-db2ldif&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-repl-monitor.pl*
> scripts/template-db2ldif.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-repl-monitor.pl.in*
> scripts/template-db2ldif.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-restoreconfig
> scripts/template-db2ldif.pl.in&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-restoreconfig.in*
> scripts/template-dsml-activate.pl&nbsp; scripts/template-saveconfig
> scripts/template-ldif2db&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-saveconfig.in*
> scripts/template-ldif2db.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-start-slapd
> scripts/template-ldif2db.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-start-slapd.in*
> scripts/template-ldif2db.pl.in&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-stop-slapd
> scripts/template-ldif2ldap&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-stop-slapd.in*
> scripts/template-ldif2ldap.in*&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-suffix2instance
> scripts/template-migrate50to51&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-suffix2instance.in*
> scripts/template-migrate5to6&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-upgradedb.in*
> scripts/template-migrate5to7&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-verify-db.pl
> scripts/template-migrate6to7&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-verify-db.pl.in
> scripts/template-migrateInstance5&nbsp; scripts/template-vlvindex
> scripts/template-migrateInstance6&nbsp; scripts/template-vlvindex.in*
> 
> --noriko
> 
> Richard Megginson wrote:
> <blockquote type=cite>Nathan Kinder wrote:
> <blockquote type=cite>Richard Megginson wrote:
> <blockquote type=cite>Nathan Kinder wrote:
> <blockquote type=cite>Richard Megginson wrote:
> <blockquote type=cite>Nathan Kinder wrote:
> <blockquote type=cite>Richard Megginson wrote:
> <blockquote type=cite>I think we can remove the files called template-"scriptname" 
>from CVS - I think we just need the template-"scriptname".in 
>files, correct?
> </blockquote>Aren't the old style builds still using these files?&nbsp; If so, we 
>should wait until we switch over to the new build on all 
>platforms and remove them along with all of the old Makefiles.
> </blockquote>With the way Makefile.am is written, it doesn't think it needs to 
>create the template-scriptname files from the 
>template-scriptname.in files because the template-scriptname 
>files already exist.&nbsp; So we will need to do some makefile hackery 
>to get around this.
> </blockquote>This would depend where you are building from.&nbsp; If you build from 
>the ldapserver directory, then what you say is true (the 
>template-scriptname file already exists).&nbsp; If you make a built 
>directory and run configure and make from there, then this isn't 
>an issue.&nbsp; The script templates listed in task_SCRIPTS in 
>Makefile.am is relative to the build directory.&nbsp; I highly suggest 
>building this way instead of building in-tree.&nbsp; It's just much 
>cleaner.
> </blockquote>rpmbuild doesn't like to build that way, but it's easy to make it 
>do that.
> </blockquote>I guess we don't need to care about keeping the tree clean when 
>using RPM build since it just gets cleaned up after the build.&nbsp; Our 
>SVbuild based builds will create a build directory though.&nbsp; Either 
>way, we should end up removing the "template-scriptname" files.&nbsp; We 
>can either cut over to the new autotools style-build and remove this 
>stuff, or we can change Makefile.am to create the 
>"template-scriptname" files in a directory other than the location 
>of the old template files.&nbsp; This second approach would still allow 
>both style builds to work for now.
> </blockquote>It's no big deal to change the rpmbuild to do this.&nbsp; Let's wait a 
>little while longer.
> 
> </blockquote>
> </blockquote></div></body>
></html>

<html>
<head>
<title>Re: It&#39;s time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</title>
<link rel="important stylesheet" href="chrome://messenger/skin/messageBody.css">
</head>
<body>
<table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part1"><tr><td><b>Subject: </b>Re: It's time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</td></tr><tr><td><b>From: </b>Richard Megginson <rmeggins@redhat.com></td></tr><tr><td><b>Date: </b>Wed, 21 Feb 2007 13:02:05 -0700</td></tr></table><table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part2"><tr><td><b>To: </b>Noriko Hosoi <nhosoi@redhat.com></td></tr><tr><td><b>CC: </b>ldap-devel-list <ldap-devel-list@redhat.com></td></tr></table><br>
<div class="moz-text-flowed">Noriko Hosoi wrote:
<br><blockquote type=cite>Rich sent out the original email some time back.&nbsp; Since we've (almost) 
finished the migration to the new style build, isn't it a good time to 
do it?&nbsp; I think to-be-eliminated files are in admin/src and 
admin/src/scripts.&nbsp; Could there be anywhere else?
<br></blockquote>I just did a quick search using this:
<br>find . -type f -print | while read file ; do if [ -f $file.in ] ; then 
ls -al $file $file.in ; fi ; done
<br>
<br>it matches your list below, so I guess there are no others.
<br><blockquote type=cite>
<br>/share/dev4/ds/ds72/builds/20070221.1/earthquake_rhel4/BUILD/fedora-ds-1.1.0-20070221/ldap/admin/src 

<br>$ ls ds_newinst.pl* scripts/template-*
<br>ds_newinst.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateInstance7
<br>ds_newinst.pl.in&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateTo5*
<br>scripts/template-bak2db&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateTo6
<br>scripts/template-bak2db.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-migrateTo7
<br>scripts/template-bak2db.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-monitor
<br>scripts/template-bak2db.pl.in&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-monitor.in*
<br>scripts/template-cl-dump.pl*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-accountstatus.pl
<br>scripts/template-cl-dump.pl.in*&nbsp;&nbsp;&nbsp; 
scripts/template-ns-accountstatus.pl.in
<br>scripts/template-db2bak&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-activate.pl
<br>scripts/template-db2bak.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-activate.pl.in
<br>scripts/template-db2bak.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-inactivate.pl
<br>scripts/template-db2bak.pl.in&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-inactivate.pl.in
<br>scripts/template-db2index&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-newpwpolicy.pl*
<br>scripts/template-db2index.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-ns-newpwpolicy.pl.in*
<br>scripts/template-db2index.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-repl-monitor-cgi.pl*
<br>scripts/template-db2index.pl.in&nbsp;&nbsp;&nbsp; 
scripts/template-repl-monitor-cgi.pl.in*
<br>scripts/template-db2ldif&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-repl-monitor.pl*
<br>scripts/template-db2ldif.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-repl-monitor.pl.in*
<br>scripts/template-db2ldif.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-restoreconfig
<br>scripts/template-db2ldif.pl.in&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-restoreconfig.in*
<br>scripts/template-dsml-activate.pl&nbsp; scripts/template-saveconfig
<br>scripts/template-ldif2db&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-saveconfig.in*
<br>scripts/template-ldif2db.in*&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-start-slapd
<br>scripts/template-ldif2db.pl&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-start-slapd.in*
<br>scripts/template-ldif2db.pl.in&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-stop-slapd
<br>scripts/template-ldif2ldap&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-stop-slapd.in*
<br>scripts/template-ldif2ldap.in*&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-suffix2instance
<br>scripts/template-migrate50to51&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-suffix2instance.in*
<br>scripts/template-migrate5to6&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-upgradedb.in*
<br>scripts/template-migrate5to7&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-verify-db.pl
<br>scripts/template-migrate6to7&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; scripts/template-verify-db.pl.in
<br>scripts/template-migrateInstance5&nbsp; scripts/template-vlvindex
<br>scripts/template-migrateInstance6&nbsp; scripts/template-vlvindex.in*
<br>
<br>--noriko
<br>
<br>Richard Megginson wrote:
<br><blockquote type=cite>Nathan Kinder wrote:
<br><blockquote type=cite>Richard Megginson wrote:
<br><blockquote type=cite>Nathan Kinder wrote:
<br><blockquote type=cite>Richard Megginson wrote:
<br><blockquote type=cite>Nathan Kinder wrote:
<br><blockquote type=cite>Richard Megginson wrote:
<br><blockquote type=cite>I think we can remove the files called template-"scriptname" 
from CVS - I think we just need the template-"scriptname".in 
files, correct?
<br></blockquote>Aren't the old style builds still using these files?&nbsp; If so, we 
should wait until we switch over to the new build on all 
platforms and remove them along with all of the old Makefiles.
<br></blockquote>With the way Makefile.am is written, it doesn't think it needs to 
create the template-scriptname files from the 
template-scriptname.in files because the template-scriptname 
files already exist.&nbsp; So we will need to do some makefile hackery 
to get around this.
<br></blockquote>This would depend where you are building from.&nbsp; If you build from 
the ldapserver directory, then what you say is true (the 
template-scriptname file already exists).&nbsp; If you make a built 
directory and run configure and make from there, then this isn't 
an issue.&nbsp; The script templates listed in task_SCRIPTS in 
Makefile.am is relative to the build directory.&nbsp; I highly suggest 
building this way instead of building in-tree.&nbsp; It's just much 
cleaner.
<br></blockquote>rpmbuild doesn't like to build that way, but it's easy to make it 
do that.
<br></blockquote>I guess we don't need to care about keeping the tree clean when 
using RPM build since it just gets cleaned up after the build.&nbsp; Our 
SVbuild based builds will create a build directory though.&nbsp; Either 
way, we should end up removing the "template-scriptname" files.&nbsp; We 
can either cut over to the new autotools style-build and remove this 
stuff, or we can change Makefile.am to create the 
"template-scriptname" files in a directory other than the location 
of the old template files.&nbsp; This second approach would still allow 
both style builds to work for now.
<br></blockquote>It's no big deal to change the rpmbuild to do this.&nbsp; Let's wait a 
little while longer.
<br>
<br></blockquote>
<br></blockquote></div></body>
</html>

Actions: View

Attachments on bug 229576: 148536 | 148538 | 274111