Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 148536 Details for
Bug 229576
clean up template-scriptname which is derived from template-scriptname.in
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
email discussion
template-scripts.html (text/html), 7.25 KB, created by
Noriko Hosoi
on 2007-02-21 21:19:33 UTC
(
hide
)
Description:
email discussion
Filename:
MIME Type:
Creator:
Noriko Hosoi
Created:
2007-02-21 21:19:33 UTC
Size:
7.25 KB
patch
obsolete
><html> ><head> ><title>Re: It's time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</title> ><link rel="important stylesheet" href="chrome://messenger/skin/messageBody.css"> ></head> ><body> ><table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part1"><tr><td><b>Subject: </b>Re: It's time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</td></tr><tr><td><b>From: </b>Richard Megginson <rmeggins@redhat.com></td></tr><tr><td><b>Date: </b>Wed, 21 Feb 2007 13:02:05 -0700</td></tr></table><table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part2"><tr><td><b>To: </b>Noriko Hosoi <nhosoi@redhat.com></td></tr><tr><td><b>CC: </b>ldap-devel-list <ldap-devel-list@redhat.com></td></tr></table><br> ><div class="moz-text-flowed">Noriko Hosoi wrote: ><br><blockquote type=cite>Rich sent out the original email some time back. Since we've (almost) >finished the migration to the new style build, isn't it a good time to >do it? I think to-be-eliminated files are in admin/src and >admin/src/scripts. Could there be anywhere else? ><br></blockquote>I just did a quick search using this: ><br>find . -type f -print | while read file ; do if [ -f $file.in ] ; then >ls -al $file $file.in ; fi ; done ><br> ><br>it matches your list below, so I guess there are no others. ><br><blockquote type=cite> ><br>/share/dev4/ds/ds72/builds/20070221.1/earthquake_rhel4/BUILD/fedora-ds-1.1.0-20070221/ldap/admin/src > ><br>$ ls ds_newinst.pl* scripts/template-* ><br>ds_newinst.pl scripts/template-migrateInstance7 ><br>ds_newinst.pl.in scripts/template-migrateTo5* ><br>scripts/template-bak2db scripts/template-migrateTo6 ><br>scripts/template-bak2db.in* scripts/template-migrateTo7 ><br>scripts/template-bak2db.pl scripts/template-monitor ><br>scripts/template-bak2db.pl.in scripts/template-monitor.in* ><br>scripts/template-cl-dump.pl* scripts/template-ns-accountstatus.pl ><br>scripts/template-cl-dump.pl.in* >scripts/template-ns-accountstatus.pl.in ><br>scripts/template-db2bak scripts/template-ns-activate.pl ><br>scripts/template-db2bak.in* scripts/template-ns-activate.pl.in ><br>scripts/template-db2bak.pl scripts/template-ns-inactivate.pl ><br>scripts/template-db2bak.pl.in scripts/template-ns-inactivate.pl.in ><br>scripts/template-db2index scripts/template-ns-newpwpolicy.pl* ><br>scripts/template-db2index.in* scripts/template-ns-newpwpolicy.pl.in* ><br>scripts/template-db2index.pl scripts/template-repl-monitor-cgi.pl* ><br>scripts/template-db2index.pl.in >scripts/template-repl-monitor-cgi.pl.in* ><br>scripts/template-db2ldif scripts/template-repl-monitor.pl* ><br>scripts/template-db2ldif.in* scripts/template-repl-monitor.pl.in* ><br>scripts/template-db2ldif.pl scripts/template-restoreconfig ><br>scripts/template-db2ldif.pl.in scripts/template-restoreconfig.in* ><br>scripts/template-dsml-activate.pl scripts/template-saveconfig ><br>scripts/template-ldif2db scripts/template-saveconfig.in* ><br>scripts/template-ldif2db.in* scripts/template-start-slapd ><br>scripts/template-ldif2db.pl scripts/template-start-slapd.in* ><br>scripts/template-ldif2db.pl.in scripts/template-stop-slapd ><br>scripts/template-ldif2ldap scripts/template-stop-slapd.in* ><br>scripts/template-ldif2ldap.in* scripts/template-suffix2instance ><br>scripts/template-migrate50to51 scripts/template-suffix2instance.in* ><br>scripts/template-migrate5to6 scripts/template-upgradedb.in* ><br>scripts/template-migrate5to7 scripts/template-verify-db.pl ><br>scripts/template-migrate6to7 scripts/template-verify-db.pl.in ><br>scripts/template-migrateInstance5 scripts/template-vlvindex ><br>scripts/template-migrateInstance6 scripts/template-vlvindex.in* ><br> ><br>--noriko ><br> ><br>Richard Megginson wrote: ><br><blockquote type=cite>Nathan Kinder wrote: ><br><blockquote type=cite>Richard Megginson wrote: ><br><blockquote type=cite>Nathan Kinder wrote: ><br><blockquote type=cite>Richard Megginson wrote: ><br><blockquote type=cite>Nathan Kinder wrote: ><br><blockquote type=cite>Richard Megginson wrote: ><br><blockquote type=cite>I think we can remove the files called template-"scriptname" >from CVS - I think we just need the template-"scriptname".in >files, correct? ><br></blockquote>Aren't the old style builds still using these files? If so, we >should wait until we switch over to the new build on all >platforms and remove them along with all of the old Makefiles. ><br></blockquote>With the way Makefile.am is written, it doesn't think it needs to >create the template-scriptname files from the >template-scriptname.in files because the template-scriptname >files already exist. So we will need to do some makefile hackery >to get around this. ><br></blockquote>This would depend where you are building from. If you build from >the ldapserver directory, then what you say is true (the >template-scriptname file already exists). If you make a built >directory and run configure and make from there, then this isn't >an issue. The script templates listed in task_SCRIPTS in >Makefile.am is relative to the build directory. I highly suggest >building this way instead of building in-tree. It's just much >cleaner. ><br></blockquote>rpmbuild doesn't like to build that way, but it's easy to make it >do that. ><br></blockquote>I guess we don't need to care about keeping the tree clean when >using RPM build since it just gets cleaned up after the build. Our >SVbuild based builds will create a build directory though. Either >way, we should end up removing the "template-scriptname" files. We >can either cut over to the new autotools style-build and remove this >stuff, or we can change Makefile.am to create the >"template-scriptname" files in a directory other than the location >of the old template files. This second approach would still allow >both style builds to work for now. ><br></blockquote>It's no big deal to change the rpmbuild to do this. Let's wait a >little while longer. ><br> ><br></blockquote> ><br></blockquote></div></body> ></html>
<html> <head> <title>Re: It's time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</title> <link rel="important stylesheet" href="chrome://messenger/skin/messageBody.css"> </head> <body> <table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part1"><tr><td><b>Subject: </b>Re: It's time to clean them up?: Do we need both template-scriptname and template-scriptname.in?</td></tr><tr><td><b>From: </b>Richard Megginson <rmeggins@redhat.com></td></tr><tr><td><b>Date: </b>Wed, 21 Feb 2007 13:02:05 -0700</td></tr></table><table border=0 cellspacing=0 cellpadding=0 width="100%" class="header-part2"><tr><td><b>To: </b>Noriko Hosoi <nhosoi@redhat.com></td></tr><tr><td><b>CC: </b>ldap-devel-list <ldap-devel-list@redhat.com></td></tr></table><br> <div class="moz-text-flowed">Noriko Hosoi wrote: <br><blockquote type=cite>Rich sent out the original email some time back. Since we've (almost) finished the migration to the new style build, isn't it a good time to do it? I think to-be-eliminated files are in admin/src and admin/src/scripts. Could there be anywhere else? <br></blockquote>I just did a quick search using this: <br>find . -type f -print | while read file ; do if [ -f $file.in ] ; then ls -al $file $file.in ; fi ; done <br> <br>it matches your list below, so I guess there are no others. <br><blockquote type=cite> <br>/share/dev4/ds/ds72/builds/20070221.1/earthquake_rhel4/BUILD/fedora-ds-1.1.0-20070221/ldap/admin/src <br>$ ls ds_newinst.pl* scripts/template-* <br>ds_newinst.pl scripts/template-migrateInstance7 <br>ds_newinst.pl.in scripts/template-migrateTo5* <br>scripts/template-bak2db scripts/template-migrateTo6 <br>scripts/template-bak2db.in* scripts/template-migrateTo7 <br>scripts/template-bak2db.pl scripts/template-monitor <br>scripts/template-bak2db.pl.in scripts/template-monitor.in* <br>scripts/template-cl-dump.pl* scripts/template-ns-accountstatus.pl <br>scripts/template-cl-dump.pl.in* scripts/template-ns-accountstatus.pl.in <br>scripts/template-db2bak scripts/template-ns-activate.pl <br>scripts/template-db2bak.in* scripts/template-ns-activate.pl.in <br>scripts/template-db2bak.pl scripts/template-ns-inactivate.pl <br>scripts/template-db2bak.pl.in scripts/template-ns-inactivate.pl.in <br>scripts/template-db2index scripts/template-ns-newpwpolicy.pl* <br>scripts/template-db2index.in* scripts/template-ns-newpwpolicy.pl.in* <br>scripts/template-db2index.pl scripts/template-repl-monitor-cgi.pl* <br>scripts/template-db2index.pl.in scripts/template-repl-monitor-cgi.pl.in* <br>scripts/template-db2ldif scripts/template-repl-monitor.pl* <br>scripts/template-db2ldif.in* scripts/template-repl-monitor.pl.in* <br>scripts/template-db2ldif.pl scripts/template-restoreconfig <br>scripts/template-db2ldif.pl.in scripts/template-restoreconfig.in* <br>scripts/template-dsml-activate.pl scripts/template-saveconfig <br>scripts/template-ldif2db scripts/template-saveconfig.in* <br>scripts/template-ldif2db.in* scripts/template-start-slapd <br>scripts/template-ldif2db.pl scripts/template-start-slapd.in* <br>scripts/template-ldif2db.pl.in scripts/template-stop-slapd <br>scripts/template-ldif2ldap scripts/template-stop-slapd.in* <br>scripts/template-ldif2ldap.in* scripts/template-suffix2instance <br>scripts/template-migrate50to51 scripts/template-suffix2instance.in* <br>scripts/template-migrate5to6 scripts/template-upgradedb.in* <br>scripts/template-migrate5to7 scripts/template-verify-db.pl <br>scripts/template-migrate6to7 scripts/template-verify-db.pl.in <br>scripts/template-migrateInstance5 scripts/template-vlvindex <br>scripts/template-migrateInstance6 scripts/template-vlvindex.in* <br> <br>--noriko <br> <br>Richard Megginson wrote: <br><blockquote type=cite>Nathan Kinder wrote: <br><blockquote type=cite>Richard Megginson wrote: <br><blockquote type=cite>Nathan Kinder wrote: <br><blockquote type=cite>Richard Megginson wrote: <br><blockquote type=cite>Nathan Kinder wrote: <br><blockquote type=cite>Richard Megginson wrote: <br><blockquote type=cite>I think we can remove the files called template-"scriptname" from CVS - I think we just need the template-"scriptname".in files, correct? <br></blockquote>Aren't the old style builds still using these files? If so, we should wait until we switch over to the new build on all platforms and remove them along with all of the old Makefiles. <br></blockquote>With the way Makefile.am is written, it doesn't think it needs to create the template-scriptname files from the template-scriptname.in files because the template-scriptname files already exist. So we will need to do some makefile hackery to get around this. <br></blockquote>This would depend where you are building from. If you build from the ldapserver directory, then what you say is true (the template-scriptname file already exists). If you make a built directory and run configure and make from there, then this isn't an issue. The script templates listed in task_SCRIPTS in Makefile.am is relative to the build directory. I highly suggest building this way instead of building in-tree. It's just much cleaner. <br></blockquote>rpmbuild doesn't like to build that way, but it's easy to make it do that. <br></blockquote>I guess we don't need to care about keeping the tree clean when using RPM build since it just gets cleaned up after the build. Our SVbuild based builds will create a build directory though. Either way, we should end up removing the "template-scriptname" files. We can either cut over to the new autotools style-build and remove this stuff, or we can change Makefile.am to create the "template-scriptname" files in a directory other than the location of the old template files. This second approach would still allow both style builds to work for now. <br></blockquote>It's no big deal to change the rpmbuild to do this. Let's wait a little while longer. <br> <br></blockquote> <br></blockquote></div></body> </html>
View Attachment As Raw
Actions:
View
Attachments on
bug 229576
: 148536 |
148538
|
274111