Attachment 1487468 Details for Bug 1633348 – Make sure we keep track the cacheline we're in while processing unions

[patch] Make sure we keep track the cacheline we're in while processing unions

uconf.cachelinep.patch (text/plain), 1.11 KB, created by Arnaldo Carvalho de Melo on 2018-09-26 20:04:36 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Arnaldo Carvalho de Melo

Created: 2018-09-26 20:04:36 UTC

Size: 1.11 KB

patch

obsolete

>diff --git a/dwarves_fprintf.c b/dwarves_fprintf.c
>index 5c87ca20123d..b4d1b18c079a 100644
>--- a/dwarves_fprintf.c
>+++ b/dwarves_fprintf.c
>@@ -828,6 +828,7 @@ static size_t union__fprintf(struct type *type, const struct cu *cu,
> 	int indent = conf->indent;
> 	struct conf_fprintf uconf;
> 	uint32_t initial_union_cacheline;
>+	int cacheline = 0; /* This will only be used if this is the outermost union */
> 
> 	if (indent >= (int)sizeof(tabs))
> 		indent = sizeof(tabs) - 1;
>@@ -839,6 +840,17 @@ static size_t union__fprintf(struct type *type, const struct cu *cu,
> 
> 	uconf = *conf;
> 	uconf.indent = indent + 1;
>+
>+	/*
>+	 * We may be called directly or from tag__fprintf, so keep sure
>+	 * we keep track of the cacheline we're in.
>+	 *
>+	 * If we're being called from an outer structure, i.e. union within
>+	 * struct, class or another union, then this will already have a
>+	 * value and we'll continue to use it.
>+	 */
>+	if (uconf.cachelinep == NULL)
>+                uconf.cachelinep = &cacheline;
> 	/*
> 	 * Save the cacheline we're in, then, after each union member, get
> 	 * back to it. Else we'll end up showing cacheline boundaries in

Actions: View | Diff

Attachments on bug 1633348: 1487408 | 1487409 | 1487410 | 1487411 | 1487412 | 1487413 | 1487414 | 1487415 | 1487416 | 1487417 | 1487418 | 1487419 | 1487468