Attachment 1487827 Details for Bug 1631741 – [PATCH] device: fix crash in nm_device_generate_connection()

[patch] [PATCH] device: fix crash in nm_device_generate_connection()

0001-device-fix-crash-in-nm_device_generate_connection.patch (text/plain), 1.05 KB, created by Beniamino Galvani on 2018-09-27 16:45:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Beniamino Galvani

Created: 2018-09-27 16:45:31 UTC

Size: 1.05 KB

patch

obsolete

>From f744e29dd368491adadf74976fc4d9e0bdbba32e Mon Sep 17 00:00:00 2001
>From: Beniamino Galvani <bgalvani@redhat.com>
>Date: Thu, 27 Sep 2018 18:07:34 +0200
>Subject: [PATCH] device: fix crash in nm_device_generate_connection()
>
>Fixes: 89d1c9fb302e84b92d0be415f0bb4bdca34ae74c
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1631741
>---
> src/devices/nm-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c
>index f025574d3..0a7cea978 100644
>--- a/src/devices/nm-device.c
>+++ b/src/devices/nm-device.c
>@@ -5522,13 +5522,13 @@ nm_device_generate_connection (NMDevice *self,
> 			              NULL);
> 		}
> 	}
> 
> 	klass->update_connection (self, connection);
> 
>-	if (!nm_connection_normalize (connection, NULL, NULL, error)) {
>+	if (!nm_connection_normalize (connection, NULL, NULL, &local)) {
> 		g_set_error (error, NM_DEVICE_ERROR, NM_DEVICE_ERROR_FAILED,
> 		             "generated connection does not verify: %s",
> 		             local->message);
> 		g_error_free (local);
> 		return NULL;
> 	}
>-- 
>2.17.1
>

Actions: View | Diff

Attachments on bug 1631741: 1487827