Attachment 149351 Details for Bug 231162 – Patch to fix leak in kadm5_get_init_creds

[patch] Patch to fix leak in kadm5_get_init_creds

krb5-1.5-kadm5_get_init_creds.patch (text/plain), 1.02 KB, created by Jerry James on 2007-03-06 16:27:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jerry James

Created: 2007-03-06 16:27:08 UTC

Size: 1.02 KB

patch

obsolete

>--- src/lib/kadm5/clnt/client_init.c.ORIG	2006-05-15 19:45:00.000000000 -0600
>+++ src/lib/kadm5/clnt/client_init.c	2007-03-03 19:57:26.000000000 -0700
>@@ -410,7 +410,7 @@
> 		      strlen(krb5_cc_get_name(handle->context, ccache)) + 2);
> 	  if (handle->cache_name == NULL) {
> 	       code = ENOMEM;
>-	       goto error;
>+	       goto error2;
> 	  }
> 	  sprintf(handle->cache_name, "%s:%s",
> 		  krb5_cc_get_type(handle->context, ccache),
>@@ -425,11 +425,11 @@
> 	  code = krb5_cc_resolve(handle->context, handle->cache_name,
> 				 &ccache);
> 	  if (code) 
>-	       goto error;
>+	       goto error2;
> 
> 	  code = krb5_cc_initialize (handle->context, ccache, client);
> 	  if (code) 
>-	       goto error;
>+	       goto error2;
> 
> 	  handle->destroy_cache = 1;
>      }
>@@ -451,6 +451,8 @@
>      if (code == KRB5KDC_ERR_S_PRINCIPAL_UNKNOWN)
> 	  code = KADM5_SECURE_PRINC_MISSING;
> 
>+error2:
>+     krb5_free_principal(handle->context, client);
> error:
>      if (ccache != NULL && init_type != INIT_CREDS)
> 	  krb5_cc_close(handle->context, ccache);

Actions: View | Diff

Attachments on bug 231162: 149351