Attachment 149474 Details for Bug 231319 – time based failover for dm multipath

[patch] time based failover for dm multipath

wait-to-fail-path.patch (text/plain), 1.95 KB, created by Josef Bacik on 2007-03-07 18:39:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Bacik

Created: 2007-03-07 18:39:51 UTC

Size: 1.95 KB

patch

obsolete

>diff -aurp linux-2.6.9/drivers/md/dm-mpath.c linux-2.6.9.work/drivers/md/dm-mpath.c
>--- linux-2.6.9/drivers/md/dm-mpath.c	2007-03-06 12:00:28.000000000 -0600
>+++ linux-2.6.9.work/drivers/md/dm-mpath.c	2007-03-06 16:50:05.000000000 -0600
>@@ -23,12 +23,19 @@
> 
> #define MESG_STR(x) x, sizeof(x)
> 
>+/*
>+ * TODO: pass this in instead of hard coding it
>+ */
>+#define DM_DEV_LOSS_TMO 30 * HZ
>+
> /* Path properties */
> struct pgpath {
> 	struct list_head list;
> 
> 	struct priority_group *pg;	/* Owning PG */
> 	unsigned fail_count;		/* Cumulative failure count */
>+	unsigned curr_fail_count;
>+	unsigned long fail_start;
> 
> 	struct path path;
> };
>@@ -836,14 +843,26 @@ static int fail_path(struct pgpath *pgpa
> 	if (!pgpath->path.is_active)
> 		goto out;
> 
>+	if (!pgpath->curr_fail_count) {
>+		pgpath->fail_start = jiffies;
>+		goto choose_new_path;
>+	} else if (time_after_eq(pgpath->fail_start + DM_DEV_LOSS_TMO,
>+				jiffies))
>+		goto choose_new_path;
>+
>+	DMWARN("dm-multipath: Path %s fail count %d.", pgpath->path.dev->name,
>+		pgpath->curr_fail_count);
>+
> 	DMWARN("dm-multipath: Failing path %s.", pgpath->path.dev->name);
> 
> 	pgpath->pg->ps.type->fail_path(&pgpath->pg->ps, &pgpath->path);
> 	pgpath->path.is_active = 0;
>-	pgpath->fail_count++;
> 
> 	m->nr_valid_paths--;
> 
>+choose_new_path:
>+	pgpath->curr_fail_count++;
>+
> 	if (pgpath == m->current_pgpath)
> 		m->current_pgpath = NULL;
> 
>@@ -866,6 +885,9 @@ static int reinstate_path(struct pgpath 
> 
> 	spin_lock_irqsave(&m->lock, flags);
> 
>+	pgpath->fail_start = 0;
>+	pgpath->curr_fail_count = 0;
>+
> 	if (pgpath->path.is_active)
> 		goto out;
> 
>@@ -1030,8 +1052,11 @@ static int do_end_io(struct multipath *m
> 	unsigned err_flags = MP_FAIL_PATH;	/* Default behavior */
> 	unsigned long flags;
> 
>-	if (!error)
>+	if (!error) {
>+		mpio->pgpath->curr_fail_count = 0;
>+		mpio->pgpath->fail_start = 0;
> 		return 0;	/* I/O complete */
>+	}
> 
> 	if ((error == -EWOULDBLOCK) && bio_rw_ahead(bio))
> 		return error;
>Only in linux-2.6.9.work/drivers/md/: .tmp_versions

Actions: View | Diff

Attachments on bug 231319: 149474 | 149734