Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 149496 Details for
Bug 231365
enhance netdump-server with extra logging
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
kenji email
kenji.txt (text/plain), 8.33 KB, created by
Neil Horman
on 2007-03-07 21:24:11 UTC
(
hide
)
Description:
kenji email
Filename:
MIME Type:
Creator:
Neil Horman
Created:
2007-03-07 21:24:11 UTC
Size:
8.33 KB
patch
obsolete
>From jmoyer@redhat.com Tue Mar 6 11:07:50 2007 >Return-Path: <jmoyer@redhat.com> >Received: from pobox.corp.redhat.com ([unix socket]) > by pobox.corp.redhat.com (Cyrus v2.2.12-Invoca-RPM-2.2.12-3.RHEL4.1) with LMTPA; > Tue, 06 Mar 2007 11:07:50 -0500 >X-Sieve: CMU Sieve 2.2 >Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) > by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26G7nLA014128 > for <nhorman@pobox.corp.redhat.com>; Tue, 6 Mar 2007 11:07:49 -0500 >Received: from mail.boston.redhat.com (mail.boston.redhat.com [172.16.76.12]) > by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26G7nL6004184 > for <nhorman@int-mx1.corp.redhat.com>; Tue, 6 Mar 2007 11:07:49 -0500 >Received: from segfault.boston.devel.redhat.com (segfault.boston.devel.redhat.com [10.12.32.26]) > by mail.boston.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l26G7mG8023466 > for <nhorman@redhat.com>; Tue, 6 Mar 2007 11:07:48 -0500 >To: Neil Horman <nhorman@redhat.com> >Subject: [Kenji Kikuchi] verbose option for netdump >X-PGP-KeyID: 1F78E1B4 >X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 >X-PCLoadLetter: What the f**k does that mean? >From: Jeff Moyer <jmoyer@redhat.com> >Date: Tue, 06 Mar 2007 11:07:48 -0500 >Message-ID: <x49vehes6cr.fsf@segfault.boston.devel.redhat.com> >User-Agent: Gnus/5.1007 (Gnus v5.10.7) XEmacs/21.5-b27 (linux) >MIME-Version: 1.0 >Content-Type: multipart/mixed; boundary="=-=-=" >Status: RO >X-Status: A >Content-Length: 7032 >Lines: 203 > >--=-=-= > >Care to open a bugzilla for this guy? > >-Jeff > > >--=-=-= >Content-Type: message/rfc822 >Content-Disposition: inline > >Return-Path: <kenji.kikuti@ctc-g.co.jp> >Received: from mail.boston.redhat.com ([unix socket]) > by mail.boston.redhat.com (Cyrus v2.1.12) with LMTP; Tue, 06 Mar 2007 08:43:40 -0500 >X-Sieve: CMU Sieve 2.2 >Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) > by mail.boston.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l26Dhb3A004241 > for <jmoyer@boston.redhat.com>; Tue, 6 Mar 2007 08:43:39 -0500 >Received: from mx2.redhat.com (mx2.redhat.com [10.255.15.25]) > by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l26DhYgO002462 > for <jmoyer@redhat.com>; Tue, 6 Mar 2007 08:43:35 -0500 >Received: from mx.ctc-g.co.jp (ns.ctc-g.co.jp [131.248.58.1]) > by mx2.redhat.com (8.13.1/8.13.1) with ESMTP id l26DhRRa013515 > for <jmoyer@redhat.com>; Tue, 6 Mar 2007 08:43:27 -0500 >Received: from msw01.ctc-g.co.jp ([131.248.242.41]) > by mx.ctc-g.co.jp (CTC-GN mail 06/11/13) id l26DMjTQ003993; > Tue, 6 Mar 2007 22:22:45 +0900 (JST) >Received: from esf01.ctc-g.co.jp (alt-pip.ctc-g.co.jp [131.248.201.248]) > by msw01.ctc-g.co.jp (8.13.8/8.13.8) with SMTP id l26DMeq7001054 > for <jmoyer@redhat.com>; Tue, 6 Mar 2007 22:22:40 +0900 >X-ESAFE-RECEIVED: by esf01.ctc-g.co.jp id 1170137427; Tue, 06 Mar 2007 22:22:40 +0900 (JST) >Received: from post01.ctc-g.co.jp ([131.248.201.248]) by mmp2-01.ctc-g.co.jp (CTC-GN mail 06/10/01) with ESMTP id <0JEH00B3AH5RE1A0@mmp2-01.ctc-g.co.jp>; > Tue, 06 Mar 2007 22:22:39 +0900 (JST) >Received: from [10.197.8.99] by smtp03.ctc-g.co.jp (CTC-GN mail 06/10/01) with ESMTP id <0JEH00K5XH5RTW20@smtp03.ctc-g.co.jp>; > Tue, 06 Mar 2007 22:22:39 +0900 (JST) >Date: Tue, 06 Mar 2007 22:22:39 +0900 >From: Kenji Kikuchi <kenji.kikuti@ctc-g.co.jp> >Subject: verbose option for netdump >To: jmoyer@redhat.com >Message-id: <45ED6B1F.6070502@ctc-g.co.jp> >X-post-Received: by post01.ctc-g.co.jp (CTC-GN 2006/10/01) id BC33374B4; Tue,6 Mar 2007 22:22:39 +0900 (JST) >X-vs: by localhost.vs01.ctc-g.co.jp (CTC-GN mail 2006/10/01) id A773816A2D;Tue, 6 Mar 2007 22:22:39 +0900 (JST) >X-vs: by vs01.ctc-g.co.jp (CTC-GN mail 2006/10/01) id 95902169D9; Tue,6 Mar 2007 22:22:39 +0900 (JST) >User-Agent: Thunderbird 1.5 (Windows/20051201) >X-ESAFE-STATUS: Mail clean >X-ESAFE-DETAILS: Clean >X-RedHat-Spam-Score: -100 >MIME-Version: 1.0 > >Dear Jeff Moyer: > > >Hi, I'm trying to send this email, because I found your address >on netdump's change log file. I would like you to consider >to added netdump verbose option for the next RHEL4 update. > >I wrote some code for the option. I believe this kind of >enhancement helps netdump user understand how it is working. >Now, most of enterprise servers seem to have > - ASR(Automatic Server Recovery) function > - large memory capacity >I think these features are making netdump difficult. > >If netdump-server itself is possible to log when reboot request >is sent to netdump-client and how many pages has been received so >far, we are easy to understand current netdump and ASR activites, >and we never doubt netdump process. > >Please check my changes. >My patch is created against netdump-0.7.16. > >Thank you in advance, > >Kenji Kikuchi > >--------------------------------------------- >diff -ur netdump-0.7.16/configuration.c netdump-0.7.16.change/configuration.c >--- netdump-0.7.16/configuration.c 2007-03-06 21:06:01.000000000 +0900 >+++ netdump-0.7.16.change/configuration.c 2007-03-06 16:30:28.000000000 +0900 >@@ -298,6 +298,8 @@ > "skip zero-filled pages in vmcore file", "1" }, > { "debug", 'D', POPT_ARG_INT, &config.debug, 0, > "debug level", "0" }, >+ { "verbose", 'v', POPT_ARG_INT, &config.verbose, 0, >+ "verbose output", "0" }, > POPT_AUTOHELP > { NULL, 0, 0, NULL, 0 } > }; >diff -ur netdump-0.7.16/configuration.h netdump-0.7.16.change/configuration.h >--- netdump-0.7.16/configuration.h 2007-03-06 21:06:01.000000000 +0900 >+++ netdump-0.7.16.change/configuration.h 2007-03-06 16:25:34.000000000 +0900 >@@ -14,6 +14,7 @@ > char *compress; > int skip_zero; > int debug; >+ int verbose; > } NetdumpConfiguration; > > extern NetdumpConfiguration config; >diff -ur netdump-0.7.16/netdumpclient.c netdump-0.7.16.change/netdumpclient.c >--- netdump-0.7.16/netdumpclient.c 2007-03-06 21:06:01.000000000 +0900 >+++ netdump-0.7.16.change/netdumpclient.c 2007-03-06 21:13:11.000000000 +0900 >@@ -187,6 +187,11 @@ > int i; > char *compress_func, *compress_command = NULL; > >+ /* Log netdump-server status */ >+ if (config_verbose()) >+ { >+ syslog (LOG_INFO, " server rebooting %s.\n", client->ip_addr); >+ } > #ifdef DEBUG > g_print (" netdump_client_destroy(%p, reboot=%d)\n", client, reboot); > #endif >@@ -982,6 +987,12 @@ > > g_free (file); > >+ /* Log netdump-server status */ >+ if (config_verbose()) >+ { >+ syslog (LOG_INFO, " server generating elf header for %s.", client->ip_addr); >+ } >+ > switch (client->machine_type) > { > case EM_386: >@@ -1076,9 +1087,22 @@ > } > } > >+ /* Log netdump-server status */ >+ if (config_verbose() && client->current_page % (guint32)(client->nr_pages / 10) == 0) >+ { >+ syslog (LOG_INFO, " server received %d0%% of pages from %s.\n", \ >+ (int)(client->current_page / (guint32)(client->nr_pages / 10)), client->ip_addr); >+ } >+ > /* Did we finish dumping all memory */ > if ((client->current_page == client->nr_pages) && !has_active) > { >+ /* Log netdump-server status */ >+ if (config_verbose()) >+ { >+ syslog (LOG_INFO, " server creating /vmcore for %s.\n", client->ip_addr); >+ } >+ > char *old_file; > char *new_file; > >@@ -2415,6 +2439,12 @@ > { > reply_t reply; > >+ /* Log netdump-server status */ >+ if (config_verbose()) >+ { >+ syslog (LOG_INFO, " server handling status information from %s\n", client->ip_addr); >+ } >+ > if (parse_packet (buffer, buf_len, &reply)) > { > syslog (LOG_WARNING, "Got invalid packet from %s\n", client->ip_addr); >diff -ur netdump-0.7.16/server.c netdump-0.7.16.change/server.c >--- netdump-0.7.16/server.c 2007-03-06 21:06:01.000000000 +0900 >+++ netdump-0.7.16.change/server.c 2007-03-06 20:48:22.000000000 +0900 >@@ -536,6 +536,13 @@ > return config.debug; > } > >+ >+int >+config_verbose(void) >+{ >+ return config.verbose; >+} >+ > int > config_load_segments(NetdumpClient *client) > { >diff -ur netdump-0.7.16/server.h netdump-0.7.16.change/server.h >--- netdump-0.7.16/server.h 2007-03-06 21:06:01.000000000 +0900 >+++ netdump-0.7.16.change/server.h 2007-03-06 16:32:54.000000000 +0900 >@@ -21,6 +21,7 @@ > int config_load_segments(NetdumpClient *client); > int config_hole_size(void); > int config_debug_level(void); >+int config_verbose(void); > char *config_compress(void); > int config_skip_zero(void); > >--------------------------------------------- > > >-- > Kenji Kikuchi > > E-mail: kenji.kikuti@ctc-g.co.jp > >--------------------------------- > > >--=-=-=-- >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Raw
Actions:
View
Attachments on
bug 231365
: 149496