Attachment 149814 Details for Bug 231820 – my idea for changes

[patch] my idea for changes

patch (text/plain), 3.50 KB, created by kenji kikuchi on 2007-03-12 10:59:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: kenji kikuchi

Created: 2007-03-12 10:59:15 UTC

Size: 3.50 KB

patch

obsolete

>diff -ur netdump-0.7.16/configuration.c netdump-0.7.16.change/configuration.c
>--- netdump-0.7.16/configuration.c	2007-03-06 21:06:01.000000000 +0900
>+++ netdump-0.7.16.change/configuration.c	2007-03-06 16:30:28.000000000 +0900
>@@ -298,6 +298,8 @@
>       "skip zero-filled pages in vmcore file", "1" },
>     { "debug", 'D', POPT_ARG_INT, &config.debug, 0,
>       "debug level", "0" },
>+    { "verbose", 'v', POPT_ARG_INT, &config.verbose, 0,
>+      "verbose output", "0" },
>       POPT_AUTOHELP
>     { NULL, 0, 0, NULL, 0 }
> };
>diff -ur netdump-0.7.16/configuration.h netdump-0.7.16.change/configuration.h
>--- netdump-0.7.16/configuration.h	2007-03-06 21:06:01.000000000 +0900
>+++ netdump-0.7.16.change/configuration.h	2007-03-06 16:25:34.000000000 +0900
>@@ -14,6 +14,7 @@
>   char *compress;
>   int skip_zero;
>   int debug;
>+  int verbose;
> } NetdumpConfiguration;
> 
> extern NetdumpConfiguration config;
>diff -ur netdump-0.7.16/netdumpclient.c netdump-0.7.16.change/netdumpclient.c
>--- netdump-0.7.16/netdumpclient.c	2007-03-06 21:06:01.000000000 +0900
>+++ netdump-0.7.16.change/netdumpclient.c	2007-03-06 21:13:11.000000000 +0900
>@@ -187,6 +187,11 @@
>   int i;
>   char *compress_func, *compress_command = NULL;
> 
>+  /* Log netdump-server status */
>+  if (config_verbose())
>+    {
>+      syslog (LOG_INFO, "   server rebooting %s.\n", client->ip_addr);
>+    }
> #ifdef DEBUG
>   g_print (" netdump_client_destroy(%p, reboot=%d)\n", client, reboot);
> #endif
>@@ -982,6 +987,12 @@
> 
>       g_free (file);
> 
>+      /* Log netdump-server status */
>+      if (config_verbose()) 
>+      {
>+        syslog (LOG_INFO, "   server generating elf header for %s.", client->ip_addr);
>+      }
>+
>       switch (client->machine_type)
>       {
>       case EM_386:
>@@ -1076,9 +1087,22 @@
> 	}
>     }
> 
>+    /* Log netdump-server status */
>+    if (config_verbose() && client->current_page % (guint32)(client->nr_pages / 10) == 0) 
>+    {
>+        syslog (LOG_INFO, "   server received %d0%% of pages from %s.\n", \
>+            (int)(client->current_page / (guint32)(client->nr_pages / 10)), client->ip_addr);
>+    }
>+
>   /* Did we finish dumping all memory */
>   if ((client->current_page == client->nr_pages) && !has_active)
>     {
>+      /* Log netdump-server status */
>+      if (config_verbose()) 
>+      {
>+          syslog (LOG_INFO, "   server creating /vmcore for %s.\n", client->ip_addr);
>+      }
>+
>       char *old_file;
>       char *new_file;
>       
>@@ -2415,6 +2439,12 @@
> {
>   reply_t reply;
>   
>+  /* Log netdump-server status */
>+  if (config_verbose())
>+    {
>+      syslog (LOG_INFO, "   server handling status information from %s\n", client->ip_addr);
>+    }
>+
>   if (parse_packet (buffer, buf_len, &reply))
>     {
>       syslog (LOG_WARNING, "Got invalid packet from %s\n", client->ip_addr);
>diff -ur netdump-0.7.16/server.c netdump-0.7.16.change/server.c
>--- netdump-0.7.16/server.c	2007-03-06 21:06:01.000000000 +0900
>+++ netdump-0.7.16.change/server.c	2007-03-06 20:48:22.000000000 +0900
>@@ -536,6 +536,13 @@
>         return config.debug;
> }
> 
>+
>+int
>+config_verbose(void)
>+{
>+        return config.verbose;
>+}
>+
> int
> config_load_segments(NetdumpClient *client)
> {
>diff -ur netdump-0.7.16/server.h netdump-0.7.16.change/server.h
>--- netdump-0.7.16/server.h	2007-03-06 21:06:01.000000000 +0900
>+++ netdump-0.7.16.change/server.h	2007-03-06 16:32:54.000000000 +0900
>@@ -21,6 +21,7 @@
> int config_load_segments(NetdumpClient *client);
> int config_hole_size(void);
> int config_debug_level(void);
>+int config_verbose(void);
> char *config_compress(void);
> int config_skip_zero(void);
>

Actions: View | Diff

Attachments on bug 231820: 149814